virtio_net: fix error return code in virtnet_probe()
authorWei Yongjun <weiyongjun1@huawei.com>
Thu, 31 May 2018 02:05:07 +0000 (02:05 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Jun 2018 02:50:13 +0000 (22:50 -0400)
Fix to return a negative error code from the failover create fail error
handling case instead of 0, as done elsewhere in this function.

Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c

index 8f08a3e..2d55e2a 100644 (file)
@@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev)
 
        if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) {
                vi->failover = net_failover_create(vi->dev);
-               if (IS_ERR(vi->failover))
+               if (IS_ERR(vi->failover)) {
+                       err = PTR_ERR(vi->failover);
                        goto free_vqs;
+               }
        }
 
        err = register_netdev(dev);