pwm: rockchip: Convert to use dev_err_probe()

It's fine to call dev_err_probe() in ->probe() when error code is known.
Convert the driver to use dev_err_probe().

Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index f3647b3..a5af859 100644 (file)
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -328,22 +328,16 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
        else
                pc->pclk = pc->clk;
 
-       if (IS_ERR(pc->pclk)) {
-               ret = PTR_ERR(pc->pclk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "Can't get APB clk: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(pc->pclk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(pc->pclk), "Can't get APB clk\n");
 
        ret = clk_prepare_enable(pc->clk);
-       if (ret) {
-               dev_err(&pdev->dev, "Can't prepare enable PWM clk: %d\n", ret);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(&pdev->dev, ret, "Can't prepare enable PWM clk\n");
 
        ret = clk_prepare_enable(pc->pclk);
        if (ret) {
-               dev_err(&pdev->dev, "Can't prepare enable APB clk: %d\n", ret);
+               dev_err_probe(&pdev->dev, ret, "Can't prepare enable APB clk\n");
                goto err_clk;
        }
 
@@ -360,7 +354,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
 
        ret = pwmchip_add(&pc->chip);
        if (ret < 0) {
-               dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret);
+               dev_err_probe(&pdev->dev, ret, "pwmchip_add() failed\n");
                goto err_pclk;
        }