v8: remove optimization switches
authorBen Noordhuis <info@bnoordhuis.nl>
Wed, 24 Oct 2012 22:52:15 +0000 (00:52 +0200)
committerBen Noordhuis <info@bnoordhuis.nl>
Wed, 24 Oct 2012 23:06:00 +0000 (01:06 +0200)
Remove compiler switches from $(TOPLEVEL)/deps/v8/build/common.gypi, we set
them globally in $(TOPLEVEL)/common.gypi.

Commit 29d12c73 accidentally reintroduced the switches again. In particular,
the 'cflags!': ['-O2','-Os'] section forced building V8 without any
optimizations, resulting in a steep (~66%) performance drop on some benchmarks.

Fixes #4191.

deps/v8/build/common.gypi

index 5d6132c..7b8a32b 100644 (file)
         'conditions': [
           ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \
             or OS=="android"', {
-            'cflags!': [
-              '-O2',
-              '-Os',
-            ],
-            'cflags': [
-              '-fdata-sections',
-              '-ffunction-sections',
-              '-fomit-frame-pointer',
-              '-O3',
-            ],
             'conditions': [
               [ 'gcc_version==44 and clang==0', {
                 'cflags': [