neighbor: Improve neighbour struct layout
authorDavid Ahern <dsahern@gmail.com>
Thu, 13 Dec 2018 16:16:50 +0000 (08:16 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 15 Dec 2018 19:49:29 +0000 (11:49 -0800)
Move arp_queue_len_bytes ahead of arp_queue to remove two 4-byte holes.
Ensure ha element is always 8-byte aligned.

Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/neighbour.h

index ef0a604..30fd50a 100644 (file)
@@ -140,8 +140,8 @@ struct neighbour {
        unsigned long           updated;
        rwlock_t                lock;
        refcount_t              refcnt;
-       struct sk_buff_head     arp_queue;
        unsigned int            arp_queue_len_bytes;
+       struct sk_buff_head     arp_queue;
        struct timer_list       timer;
        unsigned long           used;
        atomic_t                probes;
@@ -150,7 +150,7 @@ struct neighbour {
        __u8                    type;
        __u8                    dead;
        seqlock_t               ha_lock;
-       unsigned char           ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned long))];
+       unsigned char           ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned long))] __aligned(8);
        struct hh_cache         hh;
        int                     (*output)(struct neighbour *, struct sk_buff *);
        const struct neigh_ops  *ops;