perf: Fix missing raw data on tracepoint events
authorJames Clark <james.clark@arm.com>
Wed, 12 Oct 2022 14:38:57 +0000 (15:38 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 27 Oct 2022 08:27:30 +0000 (10:27 +0200)
Since commit 838d9bb62d13 ("perf: Use sample_flags for raw_data")
raw data is not being output on tracepoints due to the PERF_SAMPLE_RAW
field not being set. Fix this by setting it for tracepoint events.

This fixes the following test failure:

  perf test "sched_switch" -vvv

   35: Track with sched_switch
  --- start ---
  test child forked, pid 1828
  ...
  Using CPUID 0x00000000410fd400
  sched_switch: cpu: 2 prev_tid -14687 next_tid 0
  sched_switch: cpu: 2 prev_tid -14687 next_tid 0
  Missing sched_switch events
  4613 events recorded
  test child finished with -1
  ---- end ----
  Track with sched_switch: FAILED!

Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data")
Signed-off-by: James Clark <james.clark@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: SeongJae Park <sj@kernel.org>
Tested-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Link: https://lore.kernel.org/r/20221012143857.48198-1-james.clark@arm.com
kernel/events/core.c

index 01933db..4ec3717 100644 (file)
@@ -9846,6 +9846,7 @@ void perf_tp_event(u16 event_type, u64 count, void *record, int entry_size,
 
        perf_sample_data_init(&data, 0, 0);
        data.raw = &raw;
+       data.sample_flags |= PERF_SAMPLE_RAW;
 
        perf_trace_buf_update(record, event_type);