win32: handle ERROR_MORE_DATA

If a named pipe is being read in message mode and the next message is
longer than the nNumberOfBytesToRead parameter specifies, ReadFile
returns FALSE and GetLastError returns ERROR_MORE_DATA.

Since the API doesn't allow to return both a GError and the number of
bytes read so far, it makes more sense to return nread, and let the
client call GetLastError() himself to check if ERROR_MORE_DATA.

The current alternative loses the nread information.

https://bugzilla.gnome.org/show_bug.cgi?id=679288

diff --git a/gio/gwin32inputstream.c b/gio/gwin32inputstream.c
index 58b99e0a02878f0e04de7dcd033ba097817a74cc..21af46865acf30141e6e80e8f4105fe3471268d4 100644 (file)
--- a/gio/gwin32inputstream.c
+++ b/gio/gwin32inputstream.c
@@ -326,8 +326,17 @@ g_win32_input_stream_read (GInputStream  *stream,
         goto end;
 
       errsv = GetLastError ();
-      if (errsv == ERROR_HANDLE_EOF ||
-          errsv == ERROR_BROKEN_PIPE)
+      if (errsv == ERROR_MORE_DATA)
+        {
+          /* If a named pipe is being read in message mode and the
+           * next message is longer than the nNumberOfBytesToRead
+           * parameter specifies, ReadFile returns FALSE and
+           * GetLastError returns ERROR_MORE_DATA */
+          retval = nread;
+          goto end;
+        }
+      else if (errsv == ERROR_HANDLE_EOF ||
+               errsv == ERROR_BROKEN_PIPE)
         {
           /* TODO: the other end of a pipe may call the WriteFile
            * function with nNumberOfBytesToWrite set to zero. In this