gst_pad_check_reconfigure: only remove flag if set.

the code ifed a debug statement, that can't be right. anyway, the way it is,
we don't really need that branch, as we set the flag to unset only if set
(and that can't fail) hence the end result is always to unset the flag.

Signed-off-by: Niv Sardi <xaiki@evilgiggle.com>
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=691985

diff --git a/gst/gstpad.c b/gst/gstpad.c
index 80d4022..3ab68f7 100644 (file)
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -1407,9 +1407,10 @@ gst_pad_check_reconfigure (GstPad * pad)
 
   GST_OBJECT_LOCK (pad);
   reconfigure = GST_PAD_NEEDS_RECONFIGURE (pad);
-  if (reconfigure)
+  if (reconfigure) {
     GST_DEBUG_OBJECT (pad, "remove RECONFIGURE flag");
-  GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_NEED_RECONFIGURE);
+    GST_OBJECT_FLAG_UNSET (pad, GST_PAD_FLAG_NEED_RECONFIGURE);
+  }
   GST_OBJECT_UNLOCK (pad);
 
   return reconfigure;