[clang-format] Handle template opener/closer in braced list (#112494)
authorOwen Pan <owenpiano@gmail.com>
Fri, 18 Oct 2024 02:56:09 +0000 (19:56 -0700)
committerTobias Hieta <tobias@hieta.se>
Tue, 29 Oct 2024 09:01:26 +0000 (10:01 +0100)
Fixes #112487.

(cherry picked from commit 67f576f31d661897c5da302b8611decb7e0f9237)

clang/lib/Format/UnwrappedLineParser.cpp
clang/unittests/Format/TokenAnnotatorTest.cpp

index 631c7c62baac188892d8eaf09f25d5a2ea67dc58..a5268e153bcc5b4e79b4758da7708a8b2a507398 100644 (file)
@@ -2500,6 +2500,11 @@ bool UnwrappedLineParser::parseBracedList(bool IsAngleBracket, bool IsEnum) {
       // Assume there are no blocks inside a braced init list apart
       // from the ones we explicitly parse out (like lambdas).
       FormatTok->setBlockKind(BK_BracedInit);
+      if (!IsAngleBracket) {
+        auto *Prev = FormatTok->Previous;
+        if (Prev && Prev->is(tok::greater))
+          Prev->setFinalizedType(TT_TemplateCloser);
+      }
       nextToken();
       parseBracedList();
       break;
index 6f3ef3b646c619f39f55384f40ade8dcce00d551..4acd900ff061f82dcae1748ef56012641a1b9b7b 100644 (file)
@@ -3404,6 +3404,12 @@ TEST_F(TokenAnnotatorTest, TemplateInstantiation) {
   ASSERT_EQ(Tokens.size(), 21u) << Tokens;
   EXPECT_TOKEN(Tokens[4], tok::less, TT_TemplateOpener);
   EXPECT_TOKEN(Tokens[16], tok::greater, TT_TemplateCloser);
+
+  Tokens =
+      annotate("auto x{std::conditional_t<T::value == U::value, T, U>{}};");
+  ASSERT_EQ(Tokens.size(), 24u) << Tokens;
+  EXPECT_TOKEN(Tokens[6], tok::less, TT_TemplateOpener);
+  EXPECT_TOKEN(Tokens[18], tok::greater, TT_TemplateCloser);
 }
 
 } // namespace