drm/i915/gvt: Off by one in intel_vgpu_write_fence()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Aug 2018 06:46:02 +0000 (09:46 +0300)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Tue, 14 Aug 2018 07:26:59 +0000 (15:26 +0800)
The > should be >= here so that we don't read one element beyond the
end of the array.

Fixes: 28a60dee2ce6 ("drm/i915/gvt: vGPU HW resource management")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
drivers/gpu/drm/i915/gvt/aperture_gm.c

index 380eeb2..fe75402 100644 (file)
@@ -131,7 +131,7 @@ void intel_vgpu_write_fence(struct intel_vgpu *vgpu,
 
        assert_rpm_wakelock_held(dev_priv);
 
-       if (WARN_ON(fence > vgpu_fence_sz(vgpu)))
+       if (WARN_ON(fence >= vgpu_fence_sz(vgpu)))
                return;
 
        reg = vgpu->fence.regs[fence];