Fix SVACE, Coverity issues

- After having been compared to NULL value, pointer 'start' is dereferenced.
- Redundant comparison '(0 != forward)' is always 'true'.
- Use after free (USE_AFTER_FREE) - this->v.

Change-Id: I1860c13ac77311f249688294f90efcb3f1d4868a

diff --git a/dali/internal/accessibility/tizen-wayland/atspi/bridge-accessible.cpp b/dali/internal/accessibility/tizen-wayland/atspi/bridge-accessible.cpp
index a9dc55c..dd3bd71 100644 (file)
--- a/dali/internal/accessibility/tizen-wayland/atspi/bridge-accessible.cpp
+++ b/dali/internal/accessibility/tizen-wayland/atspi/bridge-accessible.cpp
@@ -602,11 +602,14 @@ Accessible* BridgeAccessible::CalculateNeighbor( Accessible* root, Accessible* s
     {
       auto deputy = DeputyOfProxyInParentGet( node );
       next_related_in_direction =
-          GetObjectInRelation( deputy, forward ? RelationType::FLOWS_TO : RelationType::FLOWS_FROM );
+          GetObjectInRelation( deputy, RelationType::FLOWS_TO );
     }
 
-    if( next_related_in_direction && start->GetStates()[State::DEFUNCT] )
+    if( next_related_in_direction && start && start->GetStates()[State::DEFUNCT] )
+    {
       next_related_in_direction = NULL;
+    }
+
     unsigned char want_cycle_detection = 0;
     if( next_related_in_direction )
     {

diff --git a/dali/internal/accessibility/tizen-wayland/atspi/dbus-tizen.cpp b/dali/internal/accessibility/tizen-wayland/atspi/dbus-tizen.cpp
index 45ce50d..c657284 100644 (file)
--- a/dali/internal/accessibility/tizen-wayland/atspi/dbus-tizen.cpp
+++ b/dali/internal/accessibility/tizen-wayland/atspi/dbus-tizen.cpp
@@ -756,9 +756,11 @@ struct DefaultDBusWrapper : public DBusWrapper
       destructors.push_back([=]()
         {
           DBUS_DEBUG( "unregistering interface %p", v );
+          {
+            std::lock_guard< std::mutex > lock( globalEntriesMutex );
+            globalEntries.erase( v );
+          }
           eldbus_service_interface_unregister( v );
-          std::lock_guard< std::mutex > lock( globalEntriesMutex );
-          globalEntries.erase( v );
         }
       );
     }