projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3de3583
)
[media] si2168: simplify si2168_cmd_execute() error path
author
Antti Palosaari
<crope@iki.fi>
Fri, 5 Dec 2014 17:30:44 +0000
(14:30 -0300)
committer
Mauro Carvalho Chehab
<mchehab@osg.samsung.com>
Thu, 29 Jan 2015 20:41:11 +0000
(18:41 -0200)
Remove if () from firmware command error path as there should not be
any error prone conditional logic there. Use goto labels instead.
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/si2168.c
patch
|
blob
|
history
diff --git
a/drivers/media/dvb-frontends/si2168.c
b/drivers/media/dvb-frontends/si2168.c
index
e00bc04
..
3c102e5
100644
(file)
--- a/
drivers/media/dvb-frontends/si2168.c
+++ b/
drivers/media/dvb-frontends/si2168.c
@@
-66,15
+66,11
@@
static int si2168_cmd_execute(struct i2c_client *client, struct si2168_cmd *cmd)
}
}
- ret = 0;
+ mutex_unlock(&dev->i2c_mutex);
+ return 0;
err_mutex_unlock:
mutex_unlock(&dev->i2c_mutex);
- if (ret)
- goto err;
-
- return 0;
-err:
dev_dbg(&client->dev, "failed=%d\n", ret);
return ret;
}