staging: rtl8723au: Fix sparse warnings
authorKrzysztof Konopko <kris@konagma.com>
Mon, 15 Dec 2014 15:02:14 +0000 (16:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Jan 2015 21:54:01 +0000 (13:54 -0800)
Some struct fields in wifi.h are meant to be __le16 but were declared as
unsigned short.  This was reported by sparse:

  rtw_wlan_util.c:538:24: warning: cast to restricted __le16
  rtw_wlan_util.c:1544:29: warning: cast to restricted __le16
  rtw_wlan_util.c:1546:25: warning: cast to restricted __le16

This patch updates the types of the fields in `AC_param` and
`ADDBA_request` structs to be consistent with relevant structs in
include/linux/ieee80211.h.

Signed-off-by: Krzysztof Konopko <kris@konagma.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723au/include/wifi.h

index fd3da3b..25d573c 100644 (file)
@@ -26,9 +26,9 @@
 ------------------------------------------------------------------------------*/
 
 struct AC_param {
-       unsigned char           ACI_AIFSN;
-       unsigned char           CW;
-       unsigned short  TXOP_limit;
+       u8                      ACI_AIFSN;
+       u8                      CW;
+       __le16                  TXOP_limit;
 }  __packed;
 
 struct WMM_para_element {
@@ -38,10 +38,10 @@ struct WMM_para_element {
 }  __packed;
 
 struct ADDBA_request {
-       unsigned char           dialog_token;
-       unsigned short  BA_para_set;
-       unsigned short  BA_timeout_value;
-       unsigned short  BA_starting_seqctrl;
+       u8              dialog_token;
+       __le16          BA_para_set;
+       __le16          BA_timeout_value;
+       __le16          BA_starting_seqctrl;
 }  __packed;