btrfs: remove redundant code from btrfs_free_stale_devices
authorNikolay Borisov <nborisov@suse.com>
Wed, 22 Jul 2020 08:09:24 +0000 (11:09 +0300)
committerDavid Sterba <dsterba@suse.com>
Wed, 7 Oct 2020 10:12:15 +0000 (12:12 +0200)
Following the refactor of btrfs_free_stale_devices in
7bcb8164ad94 ("btrfs: use device_list_mutex when removing stale devices")
fs_devices are freed after they have been iterated by the inner
list_for_each so the use-after-free fixed by introducing the break in
fd649f10c3d2 ("btrfs: Fix use-after-free when cleaning up fs_devs with
a single stale device") is no longer necessary. Just remove it
altogether. No functional changes.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c

index 3e3aacaedf476fdc91fe20d789626ca968273430..9355f5c78c155711d70356e047e19f10cf8f71bf 100644 (file)
@@ -595,8 +595,6 @@ static int btrfs_free_stale_devices(const char *path,
                        btrfs_free_device(device);
 
                        ret = 0;
-                       if (fs_devices->num_devices == 0)
-                               break;
                }
                mutex_unlock(&fs_devices->device_list_mutex);