projects
/
platform
/
upstream
/
ninja.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c06fdc8
)
Correct order of ASSERT_EQ arguments
author
Mike Seplowitz
<mseplowitz@bloomberg.net>
Tue, 21 Jul 2015 22:13:26 +0000
(18:13 -0400)
committer
Mike Seplowitz
<mseplowitz@bloomberg.net>
Thu, 30 Jul 2015 15:51:06 +0000
(11:51 -0400)
The correct order is ASSERT_EQ(expected, actual).
src/depfile_parser_test.cc
patch
|
blob
|
history
diff --git
a/src/depfile_parser_test.cc
b/src/depfile_parser_test.cc
index
8b57a1e
..
fe9424a
100644
(file)
--- a/
src/depfile_parser_test.cc
+++ b/
src/depfile_parser_test.cc
@@
-139,8
+139,8
@@
TEST_F(DepfileParserTest, UnifyMultipleOutputs) {
// check that multiple duplicate targets are properly unified
string err;
EXPECT_TRUE(Parse("foo foo: x y z", &err));
- ASSERT_EQ(
parser_.out_.AsString(), "foo"
);
- ASSERT_EQ(
parser_.ins_.size(), 3u
);
+ ASSERT_EQ(
"foo", parser_.out_.AsString()
);
+ ASSERT_EQ(
3u, parser_.ins_.size()
);
EXPECT_EQ("x", parser_.ins_[0].AsString());
EXPECT_EQ("y", parser_.ins_[1].AsString());
EXPECT_EQ("z", parser_.ins_[2].AsString());