drm/amd/powerplay: correct PP_TemperatureRange member type since negative values...
authorEvan Quan <evan.quan@amd.com>
Thu, 28 Dec 2017 06:07:49 +0000 (14:07 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 19 Feb 2018 19:17:05 +0000 (14:17 -0500)
Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
drivers/gpu/drm/amd/powerplay/inc/power_state.h

index d7aa643..f6573ed 100644 (file)
@@ -310,9 +310,9 @@ int smu7_thermal_get_temperature(struct pp_hwmgr *hwmgr)
 static int smu7_thermal_set_temperature_range(struct pp_hwmgr *hwmgr,
                uint32_t low_temp, uint32_t high_temp)
 {
-       uint32_t low = SMU7_THERMAL_MINIMUM_ALERT_TEMP *
+       int low = SMU7_THERMAL_MINIMUM_ALERT_TEMP *
                        PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
-       uint32_t high = SMU7_THERMAL_MAXIMUM_ALERT_TEMP *
+       int high = SMU7_THERMAL_MAXIMUM_ALERT_TEMP *
                        PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
 
        if (low < low_temp)
index dc3761b..7491163 100644 (file)
@@ -386,9 +386,9 @@ int vega10_thermal_get_temperature(struct pp_hwmgr *hwmgr)
 static int vega10_thermal_set_temperature_range(struct pp_hwmgr *hwmgr,
                struct PP_TemperatureRange *range)
 {
-       uint32_t low = VEGA10_THERMAL_MINIMUM_ALERT_TEMP *
+       int low = VEGA10_THERMAL_MINIMUM_ALERT_TEMP *
                        PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
-       uint32_t high = VEGA10_THERMAL_MAXIMUM_ALERT_TEMP *
+       int high = VEGA10_THERMAL_MAXIMUM_ALERT_TEMP *
                        PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
        uint32_t val, reg;
 
index 827860f..a99b5cb 100644 (file)
@@ -122,8 +122,8 @@ struct PP_StateSoftwareAlgorithmBlock {
  * Type to hold a temperature range.
  */
 struct PP_TemperatureRange {
-       uint32_t min;
-       uint32_t max;
+       int min;
+       int max;
 };
 
 struct PP_StateValidationBlock {