Fix coverity issues

Change-Id: I3aaab199d975b61475d231f0bcdb5588654d68e9
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>

diff --git a/src/manager_call.c b/src/manager_call.c
index 2a98aacde007395be59c6f249a4bed492eadfd45..5576fe3370849b273d851c27d71f37de3c427fa2 100644 (file)
--- a/src/manager_call.c
+++ b/src/manager_call.c
@@ -788,7 +788,7 @@ static enum tcore_manager_return __call_handle_dial_request(Server *server, User
                                                tcore_network_get_service_status(co_network,
                                                TCORE_NETWORK_SERVICE_DOMAIN_TYPE_PACKET, &ps_status)) &&
                                                (NETWORK_SERVICE_DOMAIN_STATUS_NO != ps_status)) {
-                                       dbg("PS_STATUS : %d. INDUCE Emergency to PS");
+                                       dbg("PS_STATUS : %d. INDUCE Emergency to PS", ps_status);
                                        return TCORE_MANAGER_RETURN_CONTINUE_IMS;
                                } else {
                                        err("tcore_network_get_service_status() failed or ps_status is NO_SVC : %d", ps_status);

diff --git a/src/manager_notification.c b/src/manager_notification.c
index 09df5e75724662cce2ab40a4dac8ee64cf0f0350..b1e20fcf9b2caf3ca189b0092f80d4fc9cacca61 100644 (file)
--- a/src/manager_notification.c
+++ b/src/manager_notification.c
@@ -78,7 +78,7 @@ enum tcore_manager_return manager_notification_handler(Manager *manager,
        if (mret == TCORE_MANAGER_RETURN_STOP)
                dbg("module:[0x%x] ret:[STOP]", module);
        else if (mret == TCORE_MANAGER_RETURN_CONTINUE)
-               dbg("module:[0x%x] ret:[CONTINUE], module");
+               dbg("module:[0x%x] ret:[CONTINUE]", module);
        else if (mret == TCORE_MANAGER_RETURN_CONTINUE_IMS)
                dbg("module:[0x%x] ret:[IMS]", module);
        else

diff --git a/src/manager_phonebook.c b/src/manager_phonebook.c
index 450a114a55fa44c42cc9af4c0575276f060257e0..56d08332b8b1617414d4790a9c981675685b9588 100644 (file)
--- a/src/manager_phonebook.c
+++ b/src/manager_phonebook.c
@@ -71,7 +71,7 @@ static void __on_hook_change_pb_record(UserRequest *ur, enum tcore_response_comm
                        while (g_hash_table_iter_next(&iter, &key, &value) == TRUE) {
                                index = atoi((const char *)value);
                                if (index == delete_record_req->index) { /* valid index of FDN record deleted*/
-                                       info("Deleted record index found, remove it from cache : index[%d] number[%s]", index, key);
+                                       info("Deleted record index found, remove it from cache : index[%d] number[%p]", index, key);
                                        g_hash_table_remove(mb->fdn_contacts, key);
                                }
                        }

diff --git a/src/manager_sms.c b/src/manager_sms.c
index abe35b984c4817a14ba3700af2dffb1321ad8526..a33819272b8f081a26d73044f85b9c6a6736d754 100644 (file)
--- a/src/manager_sms.c
+++ b/src/manager_sms.c
@@ -425,7 +425,7 @@ static void __sms_on_resp_get_sca_for_envelop(UserRequest *ur, enum tcore_respon
        dbg("Enter");
 
        if (G_UNLIKELY(!resp || !rp_data)) {
-               err("NULL data : resp[%p], rp_data[*p]");
+               err("NULL data : resp or rp_data");
                return;
        }
 

diff --git a/src/manager_util.c b/src/manager_util.c
index 1688923150cb055d64bf9b812a535bed39cd2b09..5cc57c27e93c88b35b0d87b64ab07f445ecefac8 100644 (file)
--- a/src/manager_util.c
+++ b/src/manager_util.c
@@ -117,7 +117,7 @@ TcorePlugin *manager_util_get_modem_plugin_by_subs_type(Server *server,
                list = g_slist_next(list);
        }
        g_slist_free(plugin_list);
-       dbg("plugin is %x", plugin);
+       dbg("plugin is %p", plugin);
        return plugin;
 }
 
@@ -216,7 +216,7 @@ void manager_util_process_pending_request(Manager *manager)
         */
        ur = manager_queue_dequeue(manager);
        while (ur != NULL) {
-               dbg("ur = %x", ur);
+               dbg("ur = %p", ur);
                /* Dispatch request to Corresponding Core Object */
                if (tcore_server_dispatch_request_ex(server, ur,
                                                     TCORE_OPS_TYPE_CP) != TCORE_RETURN_SUCCESS) {

diff --git a/src/network_name/manager_network_name.c b/src/network_name/manager_network_name.c
index 2c72ea31c840f6a45e90b321d335efc1762808cf..bcf2c1b35a2d33c9438000329c7615facb0fc840 100644 (file)
--- a/src/network_name/manager_network_name.c
+++ b/src/network_name/manager_network_name.c
@@ -1084,7 +1084,7 @@ static void __network_update_name_priority(NetworkPrivateInfo *npi)
 
        spn = tcore_sim_get_spn(npi->co_sim);
        if (!spn) {
-               warn("Cannot get spn[%s]", spn ? spn : NULL);
+               warn("Cannot get spn");
                goto out;
        }
 
@@ -1544,7 +1544,7 @@ void manager_network_get_all_eons_name_from_plmn(NetworkPrivateInfo *npi, char *
                                struct tel_sim_imsi *imsi = tcore_sim_get_imsi(npi->co_sim);
                                if (imsi && strlen(imsi->plmn) > 0) {
                                        if (__network_is_plmn_matched(npi) && g_strcmp0("50503", imsi->plmn) == 0) {
-                                               warn("change eonsname with spn name. EONS[%s] -> SPN[%s]", eonsname, spn);
+                                               warn("change eonsname with spn name. EONS[%s] -> SPN[%s]", eonsname, spn->spn);
                                                g_free(eonsname);
                                                eonsname = g_strdup((gchar *)(spn->spn));
                                        }