video: mmp: delete a stray mutex_unlock()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 14 Nov 2013 08:19:18 +0000 (11:19 +0300)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Fri, 17 Jan 2014 08:57:47 +0000 (10:57 +0200)
We aren't holding the disp_lock so we shouldn't release it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/mmp/core.c

index 84de263..c8d4265 100644 (file)
@@ -173,7 +173,7 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info)
                + sizeof(struct mmp_overlay) * info->overlay_num;
        path = kzalloc(size, GFP_KERNEL);
        if (!path)
-               goto failed;
+               return NULL;
 
        /* path set */
        mutex_init(&path->access_ok);
@@ -219,11 +219,6 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info)
 
        mutex_unlock(&disp_lock);
        return path;
-
-failed:
-       kfree(path);
-       mutex_unlock(&disp_lock);
-       return NULL;
 }
 EXPORT_SYMBOL_GPL(mmp_register_path);