Fixed space leak in DebuggerAgentSession.
authorsvenpanne@chromium.org <svenpanne@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Thu, 6 Feb 2014 12:09:08 +0000 (12:09 +0000)
committersvenpanne@chromium.org <svenpanne@chromium.org@ce2b1a6d-e550-0410-aec6-3dcde31c8c00>
Thu, 6 Feb 2014 12:09:08 +0000 (12:09 +0000)
Ownership in this part is still very convoluted and should probably be
cleaned up, this is only the minimal CL needed to fix the leak.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/153623009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19148 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

src/debug-agent.cc
src/debug-agent.h

index d3d22c9..49790ce 100644 (file)
@@ -173,6 +173,11 @@ void DebuggerAgent::DebuggerMessage(const v8::Debug::Message& message) {
 }
 
 
+DebuggerAgentSession::~DebuggerAgentSession() {
+  delete client_;
+}
+
+
 void DebuggerAgent::OnSessionClosed(DebuggerAgentSession* session) {
   // Don't do anything during termination.
   if (terminate_) {
index 138e51a..e81e4cd 100644 (file)
@@ -83,6 +83,7 @@ class DebuggerAgentSession: public Thread {
   DebuggerAgentSession(DebuggerAgent* agent, Socket* client)
       : Thread("v8:DbgAgntSessn"),
         agent_(agent), client_(client) {}
+  ~DebuggerAgentSession();
 
   void DebuggerMessage(Vector<uint16_t> message);
   void Shutdown();