media: smiapp: Destroy sensor's mutex
authorSakari Ailus <sakari.ailus@linux.intel.com>
Thu, 17 Oct 2019 11:17:05 +0000 (08:17 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 24 Oct 2019 21:54:30 +0000 (18:54 -0300)
Destroy the mutex initialised by the driver in probe.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/smiapp/smiapp-core.c

index a274527..ea118e0 100644 (file)
@@ -2881,7 +2881,6 @@ static int smiapp_probe(struct i2c_client *client)
                return -ENOMEM;
 
        sensor->hwcfg = hwcfg;
-       mutex_init(&sensor->mutex);
        sensor->src = &sensor->ssds[sensor->ssds_used];
 
        v4l2_i2c_subdev_init(&sensor->src->sd, client, &smiapp_ops);
@@ -2945,6 +2944,8 @@ static int smiapp_probe(struct i2c_client *client)
        if (rval < 0)
                return rval;
 
+       mutex_init(&sensor->mutex);
+
        rval = smiapp_identify_module(sensor);
        if (rval) {
                rval = -ENODEV;
@@ -3134,6 +3135,7 @@ out_cleanup:
 
 out_power_off:
        smiapp_power_off(&client->dev);
+       mutex_destroy(&sensor->mutex);
 
        return rval;
 }
@@ -3156,6 +3158,7 @@ static int smiapp_remove(struct i2c_client *client)
                media_entity_cleanup(&sensor->ssds[i].sd.entity);
        }
        smiapp_cleanup(sensor);
+       mutex_destroy(&sensor->mutex);
 
        return 0;
 }