ethtool: remove set but not used variable 'lsettings'
authorYueHaibing <yuehaibing@huawei.com>
Fri, 3 Jan 2020 03:48:56 +0000 (03:48 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Jan 2020 20:22:12 +0000 (12:22 -0800)
Fixes gcc '-Wunused-but-set-variable' warning:

net/ethtool/linkmodes.c: In function 'ethnl_set_linkmodes':
net/ethtool/linkmodes.c:326:32: warning:
 variable 'lsettings' set but not used [-Wunused-but-set-variable]
  struct ethtool_link_settings *lsettings;
                                ^
It is never used, so remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethtool/linkmodes.c

index 0b99f49..96f20be 100644 (file)
@@ -323,7 +323,6 @@ int ethnl_set_linkmodes(struct sk_buff *skb, struct genl_info *info)
 {
        struct nlattr *tb[ETHTOOL_A_LINKMODES_MAX + 1];
        struct ethtool_link_ksettings ksettings = {};
-       struct ethtool_link_settings *lsettings;
        struct ethnl_req_info req_info = {};
        struct net_device *dev;
        bool mod = false;
@@ -354,7 +353,6 @@ int ethnl_set_linkmodes(struct sk_buff *skb, struct genl_info *info)
                        GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
                goto out_ops;
        }
-       lsettings = &ksettings.base;
 
        ret = ethnl_update_linkmodes(info, tb, &ksettings, &mod);
        if (ret < 0)