sensord: use emplace_back instead of push_back 82/125082/1
authorkibak.yoon <seseki17@gmail.com>
Thu, 13 Apr 2017 15:30:48 +0000 (00:30 +0900)
committerkibak.yoon <seseki17@gmail.com>
Thu, 13 Apr 2017 15:30:48 +0000 (00:30 +0900)
Change-Id: I812a34b162a982dfa1ba7033bcb35e758d8d71dd
Signed-off-by: kibak.yoon <seseki17@gmail.com>
src/sensorctl/test_bench.cpp
src/server/sensor_loader.cpp

index 201a7f5..3b9cd51 100644 (file)
@@ -133,9 +133,7 @@ void test_bench::add_testcase(const std::string &group, test_case *testcase)
 
 void test_bench::add_failure(const std::string &function, long line, const std::string &msg)
 {
-       test_result fail(function, line, msg);
-
-       results.push_back(fail);
+       results.emplace_back(function, line, msg);
        m_failure_count++;
 }
 
index 4d1d20e..9ea7e7f 100644 (file)
@@ -73,7 +73,6 @@ bool sensor_loader::load(const std::string &dir_path, std::vector<std::shared_pt
        void *handle;
        std::vector<std::string> module_paths;
        void **results;
-       T *sensor;
 
        ret = get_module_paths(dir_path, module_paths);
        retv_if(!ret, false);
@@ -97,11 +96,8 @@ bool sensor_loader::load(const std::string &dir_path, std::vector<std::shared_pt
                        return false;
                }
 
-               for (int i = 0; i < size; ++i) {
-                       sensor = static_cast<T *>(results[i]);
-                       std::shared_ptr<T> sensor_ptr(sensor);
-                       sensors.push_back(sensor_ptr);
-               }
+               for (int i = 0; i < size; ++i)
+                       sensors.emplace_back(static_cast<T *>(results[i]));
 
                m_modules[path.c_str()] = handle;
        }