mm/damon/dbgfs: use operations id for knowing if the target has pid
authorSeongJae Park <sj@kernel.org>
Tue, 22 Mar 2022 21:49:01 +0000 (14:49 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 22 Mar 2022 22:57:12 +0000 (15:57 -0700)
DAMON debugfs interface depends on monitoring operations for virtual
address spaces because it knows if the target has pid or not by seeing if
the context is configured to use one of the virtual address space
monitoring operation functions.  We can replace that check with 'enum
damon_ops_id' now, to make it independent.  This commit makes the change.

Link: https://lkml.kernel.org/r/20220215184603.1479-7-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Xin Hao <xhao@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/damon/dbgfs.c

index 8bf9e38b60f47e377a015c437aa45da8cdd769b6..05b574cbcea81ce21971631af2c20ef404255b72 100644 (file)
@@ -277,7 +277,7 @@ out:
 
 static inline bool target_has_pid(const struct damon_ctx *ctx)
 {
-       return ctx->ops.target_valid == damon_va_target_valid;
+       return ctx->ops.id == DAMON_OPS_VADDR;
 }
 
 static ssize_t sprint_target_ids(struct damon_ctx *ctx, char *buf, ssize_t len)
@@ -741,8 +741,8 @@ static struct damon_ctx *dbgfs_new_ctx(void)
        if (!ctx)
                return NULL;
 
-       if (damon_select_ops(ctx, DAMON_OPS_VADDR) && damon_select_ops(ctx,
-                               DAMON_OPS_PADDR)) {
+       if (damon_select_ops(ctx, DAMON_OPS_VADDR) &&
+                       damon_select_ops(ctx, DAMON_OPS_PADDR)) {
                damon_destroy_ctx(ctx);
                return NULL;
        }