net: move __skb_checksum_complete*() to skbuff.c
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 8 Nov 2018 22:05:42 +0000 (14:05 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Nov 2018 04:38:52 +0000 (20:38 -0800)
__skb_checksum_complete_head() and __skb_checksum_complete()
are both declared in skbuff.h, they fit better in skbuff.c
than datagram.c.

Cc: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/datagram.c
net/core/skbuff.c

index 57f3a6f..07983b9 100644 (file)
@@ -728,49 +728,6 @@ fault:
        return -EFAULT;
 }
 
-__sum16 __skb_checksum_complete_head(struct sk_buff *skb, int len)
-{
-       __sum16 sum;
-
-       sum = csum_fold(skb_checksum(skb, 0, len, skb->csum));
-       if (likely(!sum)) {
-               if (unlikely(skb->ip_summed == CHECKSUM_COMPLETE) &&
-                   !skb->csum_complete_sw)
-                       netdev_rx_csum_fault(skb->dev);
-       }
-       if (!skb_shared(skb))
-               skb->csum_valid = !sum;
-       return sum;
-}
-EXPORT_SYMBOL(__skb_checksum_complete_head);
-
-__sum16 __skb_checksum_complete(struct sk_buff *skb)
-{
-       __wsum csum;
-       __sum16 sum;
-
-       csum = skb_checksum(skb, 0, skb->len, 0);
-
-       /* skb->csum holds pseudo checksum */
-       sum = csum_fold(csum_add(skb->csum, csum));
-       if (likely(!sum)) {
-               if (unlikely(skb->ip_summed == CHECKSUM_COMPLETE) &&
-                   !skb->csum_complete_sw)
-                       netdev_rx_csum_fault(skb->dev);
-       }
-
-       if (!skb_shared(skb)) {
-               /* Save full packet checksum */
-               skb->csum = csum;
-               skb->ip_summed = CHECKSUM_COMPLETE;
-               skb->csum_complete_sw = 1;
-               skb->csum_valid = !sum;
-       }
-
-       return sum;
-}
-EXPORT_SYMBOL(__skb_checksum_complete);
-
 /**
  *     skb_copy_and_csum_datagram_msg - Copy and checksum skb to user iovec.
  *     @skb: skbuff
index b4ee5c8..5cb4b34 100644 (file)
@@ -2645,6 +2645,49 @@ __wsum skb_copy_and_csum_bits(const struct sk_buff *skb, int offset,
 }
 EXPORT_SYMBOL(skb_copy_and_csum_bits);
 
+__sum16 __skb_checksum_complete_head(struct sk_buff *skb, int len)
+{
+       __sum16 sum;
+
+       sum = csum_fold(skb_checksum(skb, 0, len, skb->csum));
+       if (likely(!sum)) {
+               if (unlikely(skb->ip_summed == CHECKSUM_COMPLETE) &&
+                   !skb->csum_complete_sw)
+                       netdev_rx_csum_fault(skb->dev);
+       }
+       if (!skb_shared(skb))
+               skb->csum_valid = !sum;
+       return sum;
+}
+EXPORT_SYMBOL(__skb_checksum_complete_head);
+
+__sum16 __skb_checksum_complete(struct sk_buff *skb)
+{
+       __wsum csum;
+       __sum16 sum;
+
+       csum = skb_checksum(skb, 0, skb->len, 0);
+
+       /* skb->csum holds pseudo checksum */
+       sum = csum_fold(csum_add(skb->csum, csum));
+       if (likely(!sum)) {
+               if (unlikely(skb->ip_summed == CHECKSUM_COMPLETE) &&
+                   !skb->csum_complete_sw)
+                       netdev_rx_csum_fault(skb->dev);
+       }
+
+       if (!skb_shared(skb)) {
+               /* Save full packet checksum */
+               skb->csum = csum;
+               skb->ip_summed = CHECKSUM_COMPLETE;
+               skb->csum_complete_sw = 1;
+               skb->csum_valid = !sum;
+       }
+
+       return sum;
+}
+EXPORT_SYMBOL(__skb_checksum_complete);
+
 static __wsum warn_crc32c_csum_update(const void *buff, int len, __wsum sum)
 {
        net_warn_ratelimited(