drm/vc4: plane: Add more debugging for LBM allocation
authorMaxime Ripard <maxime@cerno.tech>
Wed, 22 Mar 2023 15:17:57 +0000 (16:17 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 19 Feb 2024 11:34:54 +0000 (11:34 +0000)
LBM allocations need a different size depending on the line length,
format, etc.

This can get tricky, and fail. Let's add some more prints to ease the
debugging when it does.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
drivers/gpu/drm/vc4/vc4_plane.c

index c5cb43b..82435c7 100644 (file)
@@ -735,6 +735,7 @@ static int vc4_plane_allocate_lbm(struct drm_plane_state *state)
 {
        struct drm_device *drm = state->plane->dev;
        struct vc4_dev *vc4 = to_vc4_dev(drm);
+       struct drm_plane *plane = state->plane;
        struct vc4_plane_state *vc4_state = to_vc4_plane_state(state);
        unsigned long irqflags;
        u32 lbm_size;
@@ -743,6 +744,9 @@ static int vc4_plane_allocate_lbm(struct drm_plane_state *state)
        if (!lbm_size)
                return 0;
 
+       drm_dbg_driver(drm, "[PLANE:%d:%s] LBM Allocation Size: %u\n",
+                      plane->base.id, plane->name, lbm_size);
+
        if (WARN_ON(!vc4_state->lbm_offset))
                return -EINVAL;