Apply RDS copy error checking.
authorDongeup Ham <dongeup.ham@samsung.com>
Tue, 6 Aug 2013 03:15:26 +0000 (12:15 +0900)
committerDongeup Ham <dongeup.ham@samsung.com>
Tue, 6 Aug 2013 03:22:03 +0000 (12:22 +0900)
Change-Id: Ic04371529e534c9ff7fdeadfcb1296c894d6bc50
Signed-off-by: Dongeup Ham <dongeup.ham@samsung.com>
inc/InstallerDefs.h
src/Manager/PermissionManager.cpp
src/Step/RdsStep.cpp

index 5b09f1f..d540d24 100755 (executable)
@@ -23,7 +23,7 @@
 
 #include "InstallerUtil.h"
 
-#define OSP_INSTALLER_VERSION "version=[20130801.2]"
+#define OSP_INSTALLER_VERSION "version=[20130806.1]"
 
 #define DIR_BIN                                L"/bin"
 #define DIR_INFO                       L"/info"
index c97881d..d37bfe3 100755 (executable)
@@ -331,12 +331,9 @@ PermissionManager::CopyForRds(InstallationContext* pContext, IList* pFileList, b
                        Directory::Create(destDir, true);
                }
                InstallerUtil::Remove(destFile);
+
                r = File::Copy(srcFile, destFile, true);
-               if (IsFailed(r) == true)
-               {
-                       AppLog("File::Copy() failed. [%ls] -> [%ls]", srcFile.GetPointer(), destFile.GetPointer());
-                       continue;
-               }
+               TryReturn(!IsFailed(r), false, "File::Copy() failed, [%ls] -> [%ls]", srcFile.GetPointer(), destFile.GetPointer());
 
                if ((destFile.Contains(pContext->__packageId + DIR_BIN) == true) && (destFile.EndsWith(L".exe") == true))
                {
index 4ac17c0..87d3b72 100755 (executable)
@@ -130,8 +130,13 @@ RdsStep::OnRdsProcessing(void)
        }
 
        PermissionManager permissionMgr;
-       permissionMgr.CopyForRds(__pContext, pAddedList.get(), __isInstallRequired);
-       permissionMgr.CopyForRds(__pContext, pModifiedList.get(), __isInstallRequired);
+
+       res = permissionMgr.CopyForRds(__pContext, pAddedList.get(), __isInstallRequired);
+       TryReturn(res, INSTALLER_ERROR_INTERNAL_STATE, "permissionMgr.CopyForRds(pAddedList) failed");
+
+       res = permissionMgr.CopyForRds(__pContext, pModifiedList.get(), __isInstallRequired);
+       TryReturn(res, INSTALLER_ERROR_INTERNAL_STATE, "permissionMgr.CopyForRds(pModifiedList) failed");
+
        permissionMgr.ApplyPermissionForRds(__pContext);
 
        GoNextState();