efl ui win - quieten coverity complaint about dead code
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Thu, 28 Sep 2017 03:17:44 +0000 (12:17 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Thu, 28 Sep 2017 06:28:00 +0000 (15:28 +0900)
the count ?: 1 check is pointless as count is already checked above.
make it clearer that it's > 0 and remove the ? check. silence for
coverity CID 1380542

src/lib/elementary/efl_ui_win.c

index 7a2a03b..4a112e5 100644 (file)
@@ -8335,21 +8335,21 @@ EAPI void
 elm_win_available_profiles_set(Elm_Win *obj, const char **profiles, unsigned int count)
 {
    if (!efl_isa(obj, MY_CLASS)) return;
-   if (count && profiles)
+   if ((count > 0) && (profiles))
      {
         Eina_Array *ar;
         unsigned int i;
 
-        ar = eina_array_new(count ?: 1);
-        for (i = 0; i < count; i++)
-          eina_array_push(ar, profiles[i]);
-        efl_ui_win_wm_available_profiles_set(obj, ar);
-        eina_array_free(ar);
-     }
-   else
-     {
-        efl_ui_win_wm_available_profiles_set(obj, NULL);
+        ar = eina_array_new(count);
+        if (ar)
+          {
+             for (i = 0; i < count; i++)
+               eina_array_push(ar, profiles[i]);
+             efl_ui_win_wm_available_profiles_set(obj, ar);
+             eina_array_free(ar);
+          }
      }
+   else efl_ui_win_wm_available_profiles_set(obj, NULL);
 }
 
 // deprecated