i2c: Convert to using %pOFn instead of device_node.name
authorRob Herring <robh@kernel.org>
Fri, 28 Sep 2018 22:49:47 +0000 (17:49 -0500)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 5 Oct 2018 12:10:40 +0000 (14:10 +0200)
In preparation to remove the node name pointer from struct device_node,
convert printf users to use the %pOFn format specifier.

Reviewed-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-powermac.c
drivers/i2c/muxes/i2c-mux-gpmux.c

index f2a2067..f6f4ed8 100644 (file)
@@ -388,9 +388,8 @@ static void i2c_powermac_register_devices(struct i2c_adapter *adap,
 static int i2c_powermac_probe(struct platform_device *dev)
 {
        struct pmac_i2c_bus *bus = dev_get_platdata(&dev->dev);
-       struct device_node *parent = NULL;
+       struct device_node *parent;
        struct i2c_adapter *adapter;
-       const char *basename;
        int rc;
 
        if (bus == NULL)
@@ -407,23 +406,25 @@ static int i2c_powermac_probe(struct platform_device *dev)
                parent = of_get_parent(pmac_i2c_get_controller(bus));
                if (parent == NULL)
                        return -EINVAL;
-               basename = parent->name;
+               snprintf(adapter->name, sizeof(adapter->name), "%pOFn %d",
+                        parent,
+                        pmac_i2c_get_channel(bus));
+               of_node_put(parent);
                break;
        case pmac_i2c_bus_pmu:
-               basename = "pmu";
+               snprintf(adapter->name, sizeof(adapter->name), "pmu %d",
+                        pmac_i2c_get_channel(bus));
                break;
        case pmac_i2c_bus_smu:
                /* This is not what we used to do but I'm fixing drivers at
                 * the same time as this change
                 */
-               basename = "smu";
+               snprintf(adapter->name, sizeof(adapter->name), "smu %d",
+                        pmac_i2c_get_channel(bus));
                break;
        default:
                return -EINVAL;
        }
-       snprintf(adapter->name, sizeof(adapter->name), "%s %d", basename,
-                pmac_i2c_get_channel(bus));
-       of_node_put(parent);
 
        platform_set_drvdata(dev, adapter);
        adapter->algo = &i2c_powermac_algorithm;
index 92cf5f4..f60b670 100644 (file)
@@ -120,8 +120,8 @@ static int i2c_mux_probe(struct platform_device *pdev)
 
                ret = of_property_read_u32(child, "reg", &chan);
                if (ret < 0) {
-                       dev_err(dev, "no reg property for node '%s'\n",
-                               child->name);
+                       dev_err(dev, "no reg property for node '%pOFn'\n",
+                               child);
                        goto err_children;
                }