eventfd is pointer. As such, it should be initialized to NULL, not to 0.
In addition, no need to initialize it after creation because the
entire structure is zeroed-out. Also, no need to initialize it before
release because the entire structure is freed.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
hdev->compute_ctx_in_release = 0;
/* release the eventfd */
- if (hpriv->notifier_event.eventfd) {
+ if (hpriv->notifier_event.eventfd)
eventfd_ctx_put(hpriv->notifier_event.eventfd);
- hpriv->notifier_event.eventfd = 0;
- }
mutex_destroy(&hpriv->notifier_event.lock);
mutex_unlock(&hdev->fpriv_ctrl_list_lock);
out:
/* release the eventfd */
- if (hpriv->notifier_event.eventfd) {
+ if (hpriv->notifier_event.eventfd)
eventfd_ctx_put(hpriv->notifier_event.eventfd);
- hpriv->notifier_event.eventfd = 0;
- }
mutex_destroy(&hpriv->notifier_event.lock);
put_pid(hpriv->taskpid);
hpriv->hdev = hdev;
filp->private_data = hpriv;
hpriv->filp = filp;
- hpriv->notifier_event.events_mask = 0;
- hpriv->notifier_event.eventfd = 0;
mutex_init(&hpriv->notifier_event.lock);
mutex_init(&hpriv->restore_phase_mutex);
hpriv->hdev = hdev;
filp->private_data = hpriv;
hpriv->filp = filp;
- hpriv->notifier_event.events_mask = 0;
- hpriv->notifier_event.eventfd = 0;
mutex_init(&hpriv->notifier_event.lock);
nonseekable_open(inode, filp);
hpriv->notifier_event.eventfd = eventfd_ctx_fdget(args->eventfd);
if (IS_ERR(hpriv->notifier_event.eventfd)) {
rc = PTR_ERR(hpriv->notifier_event.eventfd);
- hpriv->notifier_event.eventfd = 0;
+ hpriv->notifier_event.eventfd = NULL;
mutex_unlock(&hpriv->notifier_event.lock);
return rc;
}
}
eventfd_ctx_put(hpriv->notifier_event.eventfd);
- hpriv->notifier_event.eventfd = 0;
+ hpriv->notifier_event.eventfd = NULL;
mutex_unlock(&hpriv->notifier_event.lock);
return 0;
}