pds_core: add FW update feature to devlink
authorShannon Nelson <shannon.nelson@amd.com>
Wed, 19 Apr 2023 17:04:20 +0000 (10:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 Apr 2023 07:29:13 +0000 (08:29 +0100)
Add in the support for doing firmware updates.  Of the two
main banks available, a and b, this updates the one not in
use and then selects it for the next boot.

Example:
    devlink dev flash pci/0000:b2:00.0 \
    file pensando/dsc_fw_1.63.0-22.tar

Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/networking/device_drivers/ethernet/amd/pds_core.rst
drivers/net/ethernet/amd/pds_core/Makefile
drivers/net/ethernet/amd/pds_core/core.h
drivers/net/ethernet/amd/pds_core/devlink.c
drivers/net/ethernet/amd/pds_core/fw.c [new file with mode: 0644]
drivers/net/ethernet/amd/pds_core/main.c

index a48eafb..932ac03 100644 (file)
@@ -73,6 +73,16 @@ The ``pds_core`` driver reports the following versions
      - fixed
      - The revision of the ASIC for this device
 
+Firmware Management
+===================
+
+The ``flash`` command can update a the DSC firmware.  The downloaded firmware
+will be saved into either of firmware bank 1 or bank 2, whichever is not
+currently in use, and that bank will used for the next boot::
+
+  # devlink dev flash pci/0000:b5:00.0 \
+            file pensando/dsc_fw_1.63.0-22.tar
+
 Health Reporters
 ================
 
index ef76dcd..6d1d6c5 100644 (file)
@@ -7,6 +7,7 @@ pds_core-y := main.o \
              devlink.o \
              dev.o \
              adminq.o \
-             core.o
+             core.o \
+             fw.o
 
 pds_core-$(CONFIG_DEBUG_FS) += debugfs.o
index 7adbd10..7eb02b3 100644 (file)
@@ -226,6 +226,9 @@ int pdsc_fw_reporter_diagnose(struct devlink_health_reporter *reporter,
                              struct netlink_ext_ack *extack);
 int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
                     struct netlink_ext_ack *extack);
+int pdsc_dl_flash_update(struct devlink *dl,
+                        struct devlink_flash_update_params *params,
+                        struct netlink_ext_ack *extack);
 
 void __iomem *pdsc_map_dbpage(struct pdsc *pdsc, int page_num);
 
@@ -268,4 +271,6 @@ void pdsc_process_adminq(struct pdsc_qcq *qcq);
 void pdsc_work_thread(struct work_struct *work);
 irqreturn_t pdsc_adminq_isr(int irq, void *data);
 
+int pdsc_firmware_update(struct pdsc *pdsc, const struct firmware *fw,
+                        struct netlink_ext_ack *extack);
 #endif /* _PDSC_H_ */
index 89f23d6..f91d65c 100644 (file)
@@ -3,6 +3,15 @@
 
 #include "core.h"
 
+int pdsc_dl_flash_update(struct devlink *dl,
+                        struct devlink_flash_update_params *params,
+                        struct netlink_ext_ack *extack)
+{
+       struct pdsc *pdsc = devlink_priv(dl);
+
+       return pdsc_firmware_update(pdsc, params->fw, extack);
+}
+
 static char *fw_slotnames[] = {
        "fw.goldfw",
        "fw.mainfwa",
diff --git a/drivers/net/ethernet/amd/pds_core/fw.c b/drivers/net/ethernet/amd/pds_core/fw.c
new file mode 100644 (file)
index 0000000..90a811f
--- /dev/null
@@ -0,0 +1,194 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright(c) 2023 Advanced Micro Devices, Inc */
+
+#include "core.h"
+
+/* The worst case wait for the install activity is about 25 minutes when
+ * installing a new CPLD, which is very seldom.  Normal is about 30-35
+ * seconds.  Since the driver can't tell if a CPLD update will happen we
+ * set the timeout for the ugly case.
+ */
+#define PDSC_FW_INSTALL_TIMEOUT        (25 * 60)
+#define PDSC_FW_SELECT_TIMEOUT 30
+
+/* Number of periodic log updates during fw file download */
+#define PDSC_FW_INTERVAL_FRACTION      32
+
+static int pdsc_devcmd_fw_download_locked(struct pdsc *pdsc, u64 addr,
+                                         u32 offset, u32 length)
+{
+       union pds_core_dev_cmd cmd = {
+               .fw_download.opcode = PDS_CORE_CMD_FW_DOWNLOAD,
+               .fw_download.offset = cpu_to_le32(offset),
+               .fw_download.addr = cpu_to_le64(addr),
+               .fw_download.length = cpu_to_le32(length),
+       };
+       union pds_core_dev_comp comp;
+
+       return pdsc_devcmd_locked(pdsc, &cmd, &comp, pdsc->devcmd_timeout);
+}
+
+static int pdsc_devcmd_fw_install(struct pdsc *pdsc)
+{
+       union pds_core_dev_cmd cmd = {
+               .fw_control.opcode = PDS_CORE_CMD_FW_CONTROL,
+               .fw_control.oper = PDS_CORE_FW_INSTALL_ASYNC
+       };
+       union pds_core_dev_comp comp;
+       int err;
+
+       err = pdsc_devcmd(pdsc, &cmd, &comp, pdsc->devcmd_timeout);
+       if (err < 0)
+               return err;
+
+       return comp.fw_control.slot;
+}
+
+static int pdsc_devcmd_fw_activate(struct pdsc *pdsc,
+                                  enum pds_core_fw_slot slot)
+{
+       union pds_core_dev_cmd cmd = {
+               .fw_control.opcode = PDS_CORE_CMD_FW_CONTROL,
+               .fw_control.oper = PDS_CORE_FW_ACTIVATE_ASYNC,
+               .fw_control.slot = slot
+       };
+       union pds_core_dev_comp comp;
+
+       return pdsc_devcmd(pdsc, &cmd, &comp, pdsc->devcmd_timeout);
+}
+
+static int pdsc_fw_status_long_wait(struct pdsc *pdsc,
+                                   const char *label,
+                                   unsigned long timeout,
+                                   u8 fw_cmd,
+                                   struct netlink_ext_ack *extack)
+{
+       union pds_core_dev_cmd cmd = {
+               .fw_control.opcode = PDS_CORE_CMD_FW_CONTROL,
+               .fw_control.oper = fw_cmd,
+       };
+       union pds_core_dev_comp comp;
+       unsigned long start_time;
+       unsigned long end_time;
+       int err;
+
+       /* Ping on the status of the long running async install
+        * command.  We get EAGAIN while the command is still
+        * running, else we get the final command status.
+        */
+       start_time = jiffies;
+       end_time = start_time + (timeout * HZ);
+       do {
+               err = pdsc_devcmd(pdsc, &cmd, &comp, pdsc->devcmd_timeout);
+               msleep(20);
+       } while (time_before(jiffies, end_time) &&
+                (err == -EAGAIN || err == -ETIMEDOUT));
+
+       if (err == -EAGAIN || err == -ETIMEDOUT) {
+               NL_SET_ERR_MSG_MOD(extack, "Firmware wait timed out");
+               dev_err(pdsc->dev, "DEV_CMD firmware wait %s timed out\n",
+                       label);
+       } else if (err) {
+               NL_SET_ERR_MSG_MOD(extack, "Firmware wait failed");
+       }
+
+       return err;
+}
+
+int pdsc_firmware_update(struct pdsc *pdsc, const struct firmware *fw,
+                        struct netlink_ext_ack *extack)
+{
+       u32 buf_sz, copy_sz, offset;
+       struct devlink *dl;
+       int next_interval;
+       u64 data_addr;
+       int err = 0;
+       int fw_slot;
+
+       dev_info(pdsc->dev, "Installing firmware\n");
+
+       dl = priv_to_devlink(pdsc);
+       devlink_flash_update_status_notify(dl, "Preparing to flash",
+                                          NULL, 0, 0);
+
+       buf_sz = sizeof(pdsc->cmd_regs->data);
+
+       dev_dbg(pdsc->dev,
+               "downloading firmware - size %d part_sz %d nparts %lu\n",
+               (int)fw->size, buf_sz, DIV_ROUND_UP(fw->size, buf_sz));
+
+       offset = 0;
+       next_interval = 0;
+       data_addr = offsetof(struct pds_core_dev_cmd_regs, data);
+       while (offset < fw->size) {
+               if (offset >= next_interval) {
+                       devlink_flash_update_status_notify(dl, "Downloading",
+                                                          NULL, offset,
+                                                          fw->size);
+                       next_interval = offset +
+                                       (fw->size / PDSC_FW_INTERVAL_FRACTION);
+               }
+
+               copy_sz = min_t(unsigned int, buf_sz, fw->size - offset);
+               mutex_lock(&pdsc->devcmd_lock);
+               memcpy_toio(&pdsc->cmd_regs->data, fw->data + offset, copy_sz);
+               err = pdsc_devcmd_fw_download_locked(pdsc, data_addr,
+                                                    offset, copy_sz);
+               mutex_unlock(&pdsc->devcmd_lock);
+               if (err) {
+                       dev_err(pdsc->dev,
+                               "download failed offset 0x%x addr 0x%llx len 0x%x: %pe\n",
+                               offset, data_addr, copy_sz, ERR_PTR(err));
+                       NL_SET_ERR_MSG_MOD(extack, "Segment download failed");
+                       goto err_out;
+               }
+               offset += copy_sz;
+       }
+       devlink_flash_update_status_notify(dl, "Downloading", NULL,
+                                          fw->size, fw->size);
+
+       devlink_flash_update_timeout_notify(dl, "Installing", NULL,
+                                           PDSC_FW_INSTALL_TIMEOUT);
+
+       fw_slot = pdsc_devcmd_fw_install(pdsc);
+       if (fw_slot < 0) {
+               err = fw_slot;
+               dev_err(pdsc->dev, "install failed: %pe\n", ERR_PTR(err));
+               NL_SET_ERR_MSG_MOD(extack, "Failed to start firmware install");
+               goto err_out;
+       }
+
+       err = pdsc_fw_status_long_wait(pdsc, "Installing",
+                                      PDSC_FW_INSTALL_TIMEOUT,
+                                      PDS_CORE_FW_INSTALL_STATUS,
+                                      extack);
+       if (err)
+               goto err_out;
+
+       devlink_flash_update_timeout_notify(dl, "Selecting", NULL,
+                                           PDSC_FW_SELECT_TIMEOUT);
+
+       err = pdsc_devcmd_fw_activate(pdsc, fw_slot);
+       if (err) {
+               NL_SET_ERR_MSG_MOD(extack, "Failed to start firmware select");
+               goto err_out;
+       }
+
+       err = pdsc_fw_status_long_wait(pdsc, "Selecting",
+                                      PDSC_FW_SELECT_TIMEOUT,
+                                      PDS_CORE_FW_ACTIVATE_STATUS,
+                                      extack);
+       if (err)
+               goto err_out;
+
+       dev_info(pdsc->dev, "Firmware update completed, slot %d\n", fw_slot);
+
+err_out:
+       if (err)
+               devlink_flash_update_status_notify(dl, "Flash failed",
+                                                  NULL, 0, 0);
+       else
+               devlink_flash_update_status_notify(dl, "Flash done",
+                                                  NULL, 0, 0);
+       return err;
+}
index eaff311..54aaf21 100644 (file)
@@ -228,6 +228,7 @@ err_out_release_regions:
 
 static const struct devlink_ops pdsc_dl_ops = {
        .info_get       = pdsc_dl_info_get,
+       .flash_update   = pdsc_dl_flash_update,
 };
 
 static const struct devlink_ops pdsc_dl_vf_ops = {