Don't crash on an extra symbol in a version script.
authorRafael Espindola <rafael.espindola@gmail.com>
Fri, 9 Dec 2016 15:08:40 +0000 (15:08 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Fri, 9 Dec 2016 15:08:40 +0000 (15:08 +0000)
llvm-svn: 289217

lld/ELF/SymbolTable.cpp
lld/test/ELF/version-script-missing.s [new file with mode: 0644]

index de6960b..863e1c8 100644 (file)
@@ -618,7 +618,8 @@ template <class ELFT> void SymbolTable<ELFT>::handleAnonymousVersion() {
       continue;
     }
     for (SymbolBody *B : find(Ver))
-      B->symbol()->VersionId = VER_NDX_GLOBAL;
+      if (B)
+        B->symbol()->VersionId = VER_NDX_GLOBAL;
   }
 }
 
diff --git a/lld/test/ELF/version-script-missing.s b/lld/test/ELF/version-script-missing.s
new file mode 100644 (file)
index 0000000..ad4786e
--- /dev/null
@@ -0,0 +1,7 @@
+# REQUIRES: x86
+
+# We used to crash if a symbol in a version script was not in the symbol table.
+
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+# RUN: echo "{ foobar; };" > %t.script
+# RUN: ld.lld --version-script %t.script -shared %t.o -o %t.so