Remove the unused properties (#121)
author유리나/Common Platform Lab(SR)/Staff Engineer/삼성전자 <rina6350.you@samsung.com>
Fri, 3 Jan 2020 04:21:22 +0000 (13:21 +0900)
committer부정균/Common Platform Lab(SR)/Staff Engineer/삼성전자 <jk.pu@samsung.com>
Fri, 3 Jan 2020 04:21:22 +0000 (13:21 +0900)
* Remove unused property

* Remove the comment

* Change a file mode for SearchHandler

* Apply for the comment

20 files changed:
Xamarin.Forms.Core/Button.cs
Xamarin.Forms.Core/DatePicker.cs
Xamarin.Forms.Core/Editor.cs
Xamarin.Forms.Core/Entry.cs
Xamarin.Forms.Core/Frame.cs
Xamarin.Forms.Core/ImageButton.cs
Xamarin.Forms.Core/InputView.cs
Xamarin.Forms.Core/Label.cs
Xamarin.Forms.Core/Layout.cs
Xamarin.Forms.Core/ListView.cs
Xamarin.Forms.Core/NavigationPage.cs
Xamarin.Forms.Core/Picker.cs
Xamarin.Forms.Core/Properties/AssemblyInfo.cs
Xamarin.Forms.Core/RefreshView.cs
Xamarin.Forms.Core/SearchBar.cs
Xamarin.Forms.Core/Slider.cs
Xamarin.Forms.Core/Switch.cs
Xamarin.Forms.Core/TimePicker.cs
Xamarin.Forms.Platform.Tizen/Forms.cs
Xamarin.Forms.Platform.Tizen/Renderers/ButtonRenderer.cs

index 74ef701..70b3c3a 100644 (file)
@@ -37,18 +37,6 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty FontAttributesProperty = FontElement.FontAttributesProperty;
 
-               public static readonly BindableProperty BorderWidthProperty = BindableProperty.Create("BorderWidth", typeof(double), typeof(Button), -1d);
-
-               public static readonly BindableProperty BorderColorProperty = BorderElement.BorderColorProperty;
-
-               [Obsolete("BorderRadiusProperty is obsolete as of 2.5.0. Please use CornerRadius instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static readonly BindableProperty BorderRadiusProperty = BindableProperty.Create("BorderRadius", typeof(int), typeof(Button), defaultValue: DefaultBorderRadius,
-                       propertyChanged: BorderRadiusPropertyChanged);
-
-               public static readonly BindableProperty CornerRadiusProperty = BindableProperty.Create("CornerRadius", typeof(int), typeof(Button), defaultValue: BorderElement.DefaultCornerRadius,
-                       propertyChanged: CornerRadiusPropertyChanged);
-
                public static readonly BindableProperty ImageSourceProperty = ImageElement.ImageProperty;
 
                [Obsolete("ImageProperty is obsolete as of 4.0.0. Please use ImageSourceProperty instead.")]
@@ -73,38 +61,13 @@ namespace Xamarin.Forms
                        InvalidateMeasureInternal(InvalidationTrigger.MeasureChanged);
                }
 
-
-               internal static readonly BindablePropertyKey IsPressedPropertyKey = BindableProperty.CreateReadOnly(nameof(IsPressed), typeof(bool), typeof(Button), default(bool));
-               public static readonly BindableProperty IsPressedProperty = IsPressedPropertyKey.BindableProperty;
-
-
                readonly Lazy<PlatformConfigurationRegistry<Button>> _platformConfigurationRegistry;
 
-               public Color BorderColor
-               {
-                       get { return (Color)GetValue(BorderElement.BorderColorProperty); }
-                       set { SetValue(BorderElement.BorderColorProperty, value); }
-               }
-
-               [Obsolete("BorderRadius is obsolete as of 2.5.0. Please use CornerRadius instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public int BorderRadius
-               {
-                       get { return (int)GetValue(BorderRadiusProperty); }
-                       set { SetValue(BorderRadiusProperty, value); }
-               }
+               public Color BorderColor { get; set; }
 
-               public int CornerRadius
-               {
-                       get { return (int)GetValue(CornerRadiusProperty); }
-                       set { SetValue(CornerRadiusProperty, value); }
-               }
+               public int CornerRadius { get; set; }
 
-               public double BorderWidth
-               {
-                       get { return (double)GetValue(BorderWidthProperty); }
-                       set { SetValue(BorderWidthProperty, value); }
-               }
+               public double BorderWidth { get; set; }
 
                public ButtonContentLayout ContentLayout
                {
@@ -170,10 +133,10 @@ namespace Xamarin.Forms
                [EditorBrowsable(EditorBrowsableState.Never)]
                public void SendClicked() => ButtonElement.ElementClicked(this, this);
 
-               public bool IsPressed => (bool)GetValue(IsPressedProperty);
+               public bool IsPressed => false;
 
                [EditorBrowsable(EditorBrowsableState.Never)]
-               void IButtonElement.SetIsPressed(bool isPressed) => SetValue(IsPressedPropertyKey, isPressed);
+               void IButtonElement.SetIsPressed(bool isPressed) { }
 
                [EditorBrowsable(EditorBrowsableState.Never)]
                public void SendPressed() => ButtonElement.ElementPressed(this, this);
@@ -264,67 +227,13 @@ namespace Xamarin.Forms
                ImageSource IImageElement.Source => ImageSource;
                bool IImageElement.IsOpaque => false;
 
-
                void IImageElement.RaiseImageSourcePropertyChanged() => OnPropertyChanged(ImageSourceProperty.PropertyName);
 
-               int IBorderElement.CornerRadiusDefaultValue => (int)CornerRadiusProperty.DefaultValue;
-
-               Color IBorderElement.BorderColorDefaultValue => (Color)BorderColorProperty.DefaultValue;
-
-               double IBorderElement.BorderWidthDefaultValue => (double)BorderWidthProperty.DefaultValue;
-
-
-               /// <summary>
-               /// Flag to prevent overwriting the value of CornerRadius
-               /// </summary>
-               bool cornerOrBorderRadiusSetting = false;
-
-               static void BorderRadiusPropertyChanged(BindableObject bindable, object oldvalue, object newvalue)
-               {
-                       if (newvalue == oldvalue)
-                               return;
-
-                       var button = (Button)bindable;
-                       var val = (int)newvalue;
-                       if (val == DefaultBorderRadius && !button.cornerOrBorderRadiusSetting)
-                               val = BorderElement.DefaultCornerRadius;
+               int IBorderElement.CornerRadiusDefaultValue => (int)BorderElement.DefaultCornerRadius;
 
-                       var oldVal = (int)bindable.GetValue(Button.CornerRadiusProperty);
+               Color IBorderElement.BorderColorDefaultValue => (Color)BorderElement.BorderColorProperty.DefaultValue;
 
-                       if (oldVal == val)
-                               return;
-
-                       if (button.cornerOrBorderRadiusSetting) // retain until BorderRadiusProperty removed
-                               return;
-
-                       button.cornerOrBorderRadiusSetting = true;
-                       bindable.SetValue(Button.CornerRadiusProperty, val);
-                       button.cornerOrBorderRadiusSetting = false;
-               }
-
-               static void CornerRadiusPropertyChanged(BindableObject bindable, object oldvalue, object newvalue)
-               {
-                       if (newvalue == oldvalue)
-                               return;
-
-                       var button = (Button)bindable;
-                       var val = (int)newvalue;
-                       if (val == BorderElement.DefaultCornerRadius && !button.cornerOrBorderRadiusSetting)
-                               val = DefaultBorderRadius;
-
-#pragma warning disable 0618 // retain until BorderRadiusProperty removed
-                       var oldVal = (int)bindable.GetValue(Button.BorderRadiusProperty);
-#pragma warning restore
-
-                       if (oldVal == val)
-                               return;
-
-#pragma warning disable 0618 // retain until BorderRadiusProperty removed
-                       button.cornerOrBorderRadiusSetting = true;
-                       bindable.SetValue(Button.BorderRadiusProperty, val);
-                       button.cornerOrBorderRadiusSetting = false;
-#pragma warning restore
-               }
+               double IBorderElement.BorderWidthDefaultValue => (double)-1d;
 
                void ITextElement.OnTextColorPropertyChanged(Color oldValue, Color newValue)
                {
@@ -332,15 +241,12 @@ namespace Xamarin.Forms
 
                void ITextElement.OnCharacterSpacingPropertyChanged(double oldValue, double newValue)
                {
-                       InvalidateMeasure();
                }
 
-
                void IBorderElement.OnBorderColorPropertyChanged(Color oldValue, Color newValue)
                {
                }
 
-
                bool IImageController.GetLoadAsAnimation() => false;
                bool IImageElement.IsLoading => false;
 
@@ -356,10 +262,10 @@ namespace Xamarin.Forms
                {
                }
 
-               bool IBorderElement.IsCornerRadiusSet() => IsSet(CornerRadiusProperty);
-               bool IBorderElement.IsBackgroundColorSet() => IsSet(BackgroundColorProperty);
-               bool IBorderElement.IsBorderColorSet() => IsSet(BorderColorProperty);
-               bool IBorderElement.IsBorderWidthSet() => IsSet(BorderWidthProperty);
+               bool IBorderElement.IsCornerRadiusSet() => false;
+               bool IBorderElement.IsBackgroundColorSet() => false;
+               bool IBorderElement.IsBorderColorSet() => false;
+               bool IBorderElement.IsBorderWidthSet() => false;
 
 
                [DebuggerDisplay("Image Position = {Position}, Spacing = {Spacing}")]
index 1bd150a..1c352db 100644 (file)
@@ -22,8 +22,6 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty TextColorProperty = TextElement.TextColorProperty;
 
-               public static readonly BindableProperty CharacterSpacingProperty = TextElement.CharacterSpacingProperty;
-
                public static readonly BindableProperty FontFamilyProperty = FontElement.FontFamilyProperty;
 
                public static readonly BindableProperty FontSizeProperty = FontElement.FontSizeProperty;
@@ -67,11 +65,7 @@ namespace Xamarin.Forms
                        set { SetValue(TextElement.TextColorProperty, value); }
                }
 
-               public double CharacterSpacing
-               {
-                       get { return (double)GetValue(TextElement.CharacterSpacingProperty); }
-                       set { SetValue(TextElement.CharacterSpacingProperty, value); }
-               }
+               public double CharacterSpacing { get; set; }
 
                public FontAttributes FontAttributes
                {
@@ -173,7 +167,6 @@ namespace Xamarin.Forms
 
                void ITextElement.OnCharacterSpacingPropertyChanged(double oldValue, double newValue)
                {
-                       InvalidateMeasure();
                }
 
        }
index 74e6f61..2b77978 100644 (file)
@@ -18,14 +18,10 @@ namespace Xamarin.Forms
 
                public new static readonly BindableProperty TextColorProperty = InputView.TextColorProperty;
 
-               public new static readonly BindableProperty CharacterSpacingProperty = InputView.CharacterSpacingProperty;
-
                public new static readonly BindableProperty PlaceholderProperty = InputView.PlaceholderProperty;
 
                public new static readonly BindableProperty PlaceholderColorProperty = InputView.PlaceholderColorProperty;
 
-               public static readonly BindableProperty IsTextPredictionEnabledProperty = BindableProperty.Create(nameof(IsTextPredictionEnabled), typeof(bool), typeof(Editor), true, BindingMode.Default);
-
                public static readonly BindableProperty AutoSizeProperty = BindableProperty.Create(nameof(AutoSize), typeof(EditorAutoSizeOption), typeof(Editor), defaultValue: EditorAutoSizeOption.Disabled, propertyChanged: (bindable, oldValue, newValue)
                        => ((Editor)bindable)?.InvalidateMeasure());
 
@@ -43,11 +39,7 @@ namespace Xamarin.Forms
                        set { SetValue(FontAttributesProperty, value); }
                }
 
-               public bool IsTextPredictionEnabled
-               {
-                       get { return (bool)GetValue(IsTextPredictionEnabledProperty); }
-                       set { SetValue(IsTextPredictionEnabledProperty, value); }
-               }
+               public bool IsTextPredictionEnabled { get; set; }
 
                public string FontFamily
                {
index 0cc8499..b52a5ae 100644 (file)
@@ -25,8 +25,6 @@ namespace Xamarin.Forms
 
                public new static readonly BindableProperty TextColorProperty = InputView.TextColorProperty;
 
-               public new static readonly BindableProperty CharacterSpacingProperty = InputView.CharacterSpacingProperty;
-
                public static readonly BindableProperty HorizontalTextAlignmentProperty = TextAlignmentElement.HorizontalTextAlignmentProperty;
 
                public static readonly BindableProperty VerticalTextAlignmentProperty = TextAlignmentElement.VerticalTextAlignmentProperty;
index 63bfe09..714b30b 100644 (file)
@@ -8,10 +8,6 @@ namespace Xamarin.Forms
        [RenderWith(typeof(_FrameRenderer))]
        public class Frame : ContentView, IElementConfiguration<Frame>, IPaddingElement, IBorderElement
        {
-               [Obsolete("OutlineColorProperty is obsolete as of version 3.0.0. Please use BorderColorProperty instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static readonly BindableProperty OutlineColorProperty = BorderElement.BorderColorProperty;
-
                public static readonly BindableProperty BorderColorProperty = BorderElement.BorderColorProperty;
 
                public static readonly BindableProperty HasShadowProperty = BindableProperty.Create("HasShadow", typeof(bool), typeof(Frame), true);
@@ -37,14 +33,6 @@ namespace Xamarin.Forms
                        set { SetValue(HasShadowProperty, value); }
                }
 
-               [Obsolete("OutlineColor is obsolete as of version 3.0.0. Please use BorderColor instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public Color OutlineColor
-               {
-                       get { return (Color)GetValue(OutlineColorProperty); }
-                       set { SetValue(OutlineColorProperty, value); }
-               }
-
                public Color BorderColor
                {
                        get { return (Color)GetValue(BorderElement.BorderColorProperty); }
@@ -75,9 +63,6 @@ namespace Xamarin.Forms
 
                void IBorderElement.OnBorderColorPropertyChanged(Color oldValue, Color newValue)
                {
-#pragma warning disable 0618 // retain until OutlineColor removed
-                       OnPropertyChanged(nameof(OutlineColor));
-#pragma warning restore
                }
 
                bool IBorderElement.IsCornerRadiusSet() => IsSet(CornerRadiusProperty);
index 1e73dba..32ceb6e 100644 (file)
@@ -33,10 +33,6 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty IsLoadingProperty = IsLoadingPropertyKey.BindableProperty;
 
-               internal static readonly BindablePropertyKey IsPressedPropertyKey = BindableProperty.CreateReadOnly(nameof(IsPressed), typeof(bool), typeof(ImageButton), default(bool));
-
-               public static readonly BindableProperty IsPressedProperty = IsPressedPropertyKey.BindableProperty;
-
                public static readonly BindableProperty PaddingProperty = PaddingElement.PaddingProperty;
 
                public event EventHandler Clicked;
@@ -77,7 +73,7 @@ namespace Xamarin.Forms
 
                public bool IsLoading => (bool)GetValue(IsLoadingProperty);
 
-               public bool IsPressed => (bool)GetValue(IsPressedProperty);
+               public bool IsPressed => false;
 
                public bool IsOpaque
                {
@@ -147,9 +143,7 @@ namespace Xamarin.Forms
                [EditorBrowsable(EditorBrowsableState.Never)]
                public void SetIsLoading(bool isLoading) => SetValue(IsLoadingPropertyKey, isLoading);
 
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public void SetIsPressed(bool isPressed) =>
-                       SetValue(IsPressedPropertyKey, isPressed);
+               public void SetIsPressed(bool isPressed) { }
 
                [EditorBrowsable(EditorBrowsableState.Never)]
                public void SendClicked() =>
index f7490cb..8e4d853 100644 (file)
@@ -95,7 +95,6 @@ namespace Xamarin.Forms
 
                void ITextElement.OnCharacterSpacingPropertyChanged(double oldValue, double newValue)
                {
-                       InvalidateMeasure();
                }
        }
 
index 9126181..2b852f5 100644 (file)
@@ -15,17 +15,9 @@ namespace Xamarin.Forms
        {
                public static readonly BindableProperty HorizontalTextAlignmentProperty = TextAlignmentElement.HorizontalTextAlignmentProperty;
 
-               [Obsolete("XAlignProperty is obsolete as of version 2.0.0. Please use HorizontalTextAlignmentProperty instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static readonly BindableProperty XAlignProperty = HorizontalTextAlignmentProperty;
-
                public static readonly BindableProperty VerticalTextAlignmentProperty = BindableProperty.Create("VerticalTextAlignment", typeof(TextAlignment), typeof(Label), TextAlignment.Start,
                        propertyChanged: OnVerticalTextAlignmentPropertyChanged);
 
-               [Obsolete("YAlignProperty is obsolete as of version 2.0.0. Please use VerticalTextAlignmentProperty instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static readonly BindableProperty YAlignProperty = VerticalTextAlignmentProperty;
-
                public static readonly BindableProperty TextColorProperty = TextElement.TextColorProperty;
 
                public static readonly BindableProperty CharacterSpacingProperty = TextElement.CharacterSpacingProperty;
@@ -80,14 +72,6 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty LineHeightProperty = LineHeightElement.LineHeightProperty;
 
-               public static readonly BindableProperty MaxLinesProperty = BindableProperty.Create(nameof(MaxLines), typeof(int), typeof(Label), -1, propertyChanged: (bindable, oldvalue, newvalue) =>
-                       {
-                               if (bindable != null)
-                               {
-                                       ((Label)bindable).InvalidateMeasureInternal(InvalidationTrigger.MeasureChanged);
-                               }
-                       });
-
                public static readonly BindableProperty PaddingProperty = PaddingElement.PaddingProperty;
                
                public static readonly BindableProperty TextTypeProperty = BindableProperty.Create(nameof(TextType), typeof(TextType), typeof(Label), TextType.Text,
@@ -157,22 +141,6 @@ namespace Xamarin.Forms
                        set { SetValue(VerticalTextAlignmentProperty, value); }
                }
 
-               [Obsolete("XAlign is obsolete as of version 2.0.0. Please use HorizontalTextAlignment instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public TextAlignment XAlign
-               {
-                       get { return (TextAlignment)GetValue(XAlignProperty); }
-                       set { SetValue(XAlignProperty, value); }
-               }
-
-               [Obsolete("YAlign is obsolete as of version 2.0.0. Please use VerticalTextAlignment instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public TextAlignment YAlign
-               {
-                       get { return (TextAlignment)GetValue(YAlignProperty); }
-                       set { SetValue(YAlignProperty, value); }
-               }
-
                public FontAttributes FontAttributes
                {
                        get { return (FontAttributes)GetValue(FontAttributesProperty); }
@@ -204,12 +172,6 @@ namespace Xamarin.Forms
                        set { SetValue(LineHeightProperty, value); }
                }
 
-               public int MaxLines
-               {
-                       get => (int)GetValue(MaxLinesProperty);
-                       set => SetValue(MaxLinesProperty, value);
-               }
-
                public Thickness Padding
                {
                        get { return (Thickness)GetValue(PaddingProperty); }
@@ -327,9 +289,6 @@ namespace Xamarin.Forms
 
                void ITextAlignmentElement.OnHorizontalTextAlignmentPropertyChanged(TextAlignment oldValue, TextAlignment newValue)
                {
-#pragma warning disable 0618 // retain until XAlign removed
-                       OnPropertyChanged(nameof(XAlign));
-#pragma warning restore
                }
 
                static void OnTextPropertyChanged(BindableObject bindable, object oldvalue, object newvalue)
@@ -346,10 +305,6 @@ namespace Xamarin.Forms
 
                static void OnVerticalTextAlignmentPropertyChanged(BindableObject bindable, object oldValue, object newValue)
                {
-                       var label = (Label)bindable;
-#pragma warning disable 0618 // retain until YAlign removed
-                       label.OnPropertyChanged(nameof(YAlign));
-#pragma warning restore 0618
                }
 
                public IPlatformElementConfiguration<T, Label> On<T>() where T : IConfigPlatform
@@ -363,10 +318,8 @@ namespace Xamarin.Forms
 
                void ITextElement.OnCharacterSpacingPropertyChanged(double oldValue, double newValue)
                {
-                       InvalidateMeasure();
                }
 
-
                public override IList<GestureElement> GetChildElements(Point point)
                {
                        if (FormattedText?.Spans == null || FormattedText?.Spans.Count == 0)
index 64e7d5b..98badd4 100644 (file)
@@ -52,8 +52,6 @@ namespace Xamarin.Forms
 
        public abstract class Layout : View, ILayout, ILayoutController, IPaddingElement
        {
-               public static readonly BindableProperty IsClippedToBoundsProperty = BindableProperty.Create("IsClippedToBounds", typeof(bool), typeof(Layout), false);
-
                public static readonly BindableProperty CascadeInputTransparentProperty = BindableProperty.Create(
                        nameof(CascadeInputTransparent), typeof(bool), typeof(Layout), true);
 
@@ -77,12 +75,6 @@ namespace Xamarin.Forms
                        InternalChildren.CollectionChanged += InternalChildrenOnCollectionChanged;
                }
 
-               public bool IsClippedToBounds
-               {
-                       get { return (bool)GetValue(IsClippedToBoundsProperty); }
-                       set { SetValue(IsClippedToBoundsProperty, value); }
-               }
-
                public Thickness Padding
                {
                        get { return (Thickness)GetValue(PaddingElement.PaddingProperty); }
index cd8ecd6..03cc6c1 100644 (file)
@@ -12,10 +12,6 @@ namespace Xamarin.Forms
        [RenderWith(typeof(_ListViewRenderer))]
        public class ListView : ItemsView<Cell>, IListViewController, IElementConfiguration<ListView>
        {
-               public static readonly BindableProperty IsPullToRefreshEnabledProperty = BindableProperty.Create("IsPullToRefreshEnabled", typeof(bool), typeof(ListView), false);
-
-               public static readonly BindableProperty IsRefreshingProperty = BindableProperty.Create("IsRefreshing", typeof(bool), typeof(ListView), false, BindingMode.TwoWay);
-
                public static readonly BindableProperty RefreshCommandProperty = BindableProperty.Create("RefreshCommand", typeof(ICommand), typeof(ListView), null, propertyChanged: OnRefreshCommandChanged);
 
                public static readonly BindableProperty HeaderProperty = BindableProperty.Create("Header", typeof(object), typeof(ListView), null, propertyChanged: OnHeaderChanged);
@@ -44,14 +40,6 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty SeparatorVisibilityProperty = BindableProperty.Create("SeparatorVisibility", typeof(SeparatorVisibility), typeof(ListView), SeparatorVisibility.Default);
 
-               public static readonly BindableProperty SeparatorColorProperty = BindableProperty.Create("SeparatorColor", typeof(Color), typeof(ListView), Color.Default);
-
-               public static readonly BindableProperty RefreshControlColorProperty = BindableProperty.Create(nameof(RefreshControlColor), typeof(Color), typeof(ListView), Color.Default);
-       
-               public static readonly BindableProperty HorizontalScrollBarVisibilityProperty = BindableProperty.Create(nameof(HorizontalScrollBarVisibility), typeof(ScrollBarVisibility), typeof(ListView), ScrollBarVisibility.Default);
-
-               public static readonly BindableProperty VerticalScrollBarVisibilityProperty = BindableProperty.Create(nameof(VerticalScrollBarVisibility), typeof(ScrollBarVisibility), typeof(ListView), ScrollBarVisibility.Default);
-
                static readonly ToStringValueConverter _toStringValueConverter = new ToStringValueConverter();
 
                readonly Lazy<PlatformConfigurationRegistry<ListView>> _platformConfigurationRegistry;
@@ -183,18 +171,6 @@ namespace Xamarin.Forms
                        set { SetValue(IsGroupingEnabledProperty, value); }
                }
 
-               public bool IsPullToRefreshEnabled
-               {
-                       get { return (bool)GetValue(IsPullToRefreshEnabledProperty); }
-                       set { SetValue(IsPullToRefreshEnabledProperty, value); }
-               }
-
-               public bool IsRefreshing
-               {
-                       get { return (bool)GetValue(IsRefreshingProperty); }
-                       set { SetValue(IsRefreshingProperty, value); }
-               }
-
                public ICommand RefreshCommand
                {
                        get { return (ICommand)GetValue(RefreshCommandProperty); }
@@ -219,35 +195,12 @@ namespace Xamarin.Forms
                        set { SetValue(SelectionModeProperty, value); }
                }
 
-               public Color SeparatorColor
-               {
-                       get { return (Color)GetValue(SeparatorColorProperty); }
-                       set { SetValue(SeparatorColorProperty, value); }
-               }
-
-               public Color RefreshControlColor
-               {
-                       get { return (Color)GetValue(RefreshControlColorProperty); }
-                       set { SetValue(RefreshControlColorProperty, value); }
-               }
-
                public SeparatorVisibility SeparatorVisibility
                {
                        get { return (SeparatorVisibility)GetValue(SeparatorVisibilityProperty); }
                        set { SetValue(SeparatorVisibilityProperty, value); }
                }
 
-               public ScrollBarVisibility HorizontalScrollBarVisibility
-               {
-                       get { return (ScrollBarVisibility)GetValue(HorizontalScrollBarVisibilityProperty); }
-                       set { SetValue(HorizontalScrollBarVisibilityProperty, value); }
-               }
-               public ScrollBarVisibility VerticalScrollBarVisibility
-               {
-                       get { return (ScrollBarVisibility)GetValue(VerticalScrollBarVisibilityProperty); }
-                       set { SetValue(VerticalScrollBarVisibilityProperty, value); }
-               }
-
                public ListViewCachingStrategy CachingStrategy { get; private set; }
 
                [EditorBrowsable(EditorBrowsableState.Never)]
@@ -299,7 +252,6 @@ namespace Xamarin.Forms
                        if (!RefreshAllowed)
                                return;
 
-                       SetValueCore(IsRefreshingProperty, true);
                        OnRefreshing(EventArgs.Empty);
 
                        ICommand command = RefreshCommand;
@@ -309,7 +261,6 @@ namespace Xamarin.Forms
 
                public void EndRefresh()
                {
-                       SetValueCore(IsRefreshingProperty, false);
                }
 
                public event EventHandler<ItemVisibilityEventArgs> ItemAppearing;
index 28a68cc..10e4cec 100644 (file)
@@ -18,20 +18,10 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty HasBackButtonProperty = BindableProperty.CreateAttached("HasBackButton", typeof(bool), typeof(NavigationPage), true);
 
-               [Obsolete("TintProperty is obsolete as of version 1.2.0. Please use BarBackgroundColorProperty and BarTextColorProperty to change NavigationPage bar color properties.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static readonly BindableProperty TintProperty = BindableProperty.Create("Tint", typeof(Color), typeof(NavigationPage), Color.Default);
-
                public static readonly BindableProperty BarBackgroundColorProperty = BarElement.BarBackgroundColorProperty;
 
                public static readonly BindableProperty BarTextColorProperty = BarElement.BarTextColorProperty;
 
-               public static readonly BindableProperty TitleIconImageSourceProperty = BindableProperty.CreateAttached("TitleIconImageSource", typeof(ImageSource), typeof(NavigationPage), default(ImageSource));
-
-               [Obsolete("TitleIconProperty is obsolete as of 4.0.0. Please use TitleIconImageSourceProperty instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static readonly BindableProperty TitleIconProperty = TitleIconImageSourceProperty;
-
                public static readonly BindableProperty TitleViewProperty = BindableProperty.CreateAttached("TitleView", typeof(View), typeof(NavigationPage), null, propertyChanging: TitleViewPropertyChanging);
 
                static readonly BindablePropertyKey CurrentPagePropertyKey = BindableProperty.CreateReadOnly("CurrentPage", typeof(Page), typeof(NavigationPage), null);
@@ -62,14 +52,6 @@ namespace Xamarin.Forms
                        set => SetValue(BarElement.BarTextColorProperty, value);
                }
 
-               [Obsolete("Tint is obsolete as of version 1.2.0. Please use BarBackgroundColor and BarTextColor to change NavigationPage bar color properties.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public Color Tint
-               {
-                       get { return (Color)GetValue(TintProperty); }
-                       set { SetValue(TintProperty, value); }
-               }
-
                internal Task CurrentNavigationTask { get; set; }
 
                [EditorBrowsable(EditorBrowsableState.Never)]
@@ -142,18 +124,6 @@ namespace Xamarin.Forms
                        return (bool)page.GetValue(HasNavigationBarProperty);
                }
 
-               [Obsolete("GetTitleIcon is obsolete as of 4.0.0. Please use GetTitleIconImageSource instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static FileImageSource GetTitleIcon(BindableObject bindable)
-               {
-                       return bindable.GetValue(TitleIconImageSourceProperty) as FileImageSource;
-               }
-
-               public static ImageSource GetTitleIconImageSource(BindableObject bindable)
-               {
-                       return (ImageSource)bindable.GetValue(TitleIconImageSourceProperty);
-               }
-
                public static View GetTitleView(BindableObject bindable)
                {
                        return (View)bindable.GetValue(TitleViewProperty);
@@ -261,18 +231,6 @@ namespace Xamarin.Forms
                        page.SetValue(HasNavigationBarProperty, value);
                }
 
-               [Obsolete("SetTitleIcon is obsolete as of 4.0.0. Please use SetTitleIconImageSource instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static void SetTitleIcon(BindableObject bindable, FileImageSource value)
-               {
-                       bindable.SetValue(TitleIconImageSourceProperty, value);
-               }
-
-               public static void SetTitleIconImageSource(BindableObject bindable, ImageSource value)
-               {
-                       bindable.SetValue(TitleIconImageSourceProperty, value);
-               }
-
                public static void SetTitleView(BindableObject bindable, View value)
                {
                        bindable.SetValue(TitleViewProperty, value);
index 56f10fd..b0f6415 100644 (file)
@@ -15,8 +15,6 @@ namespace Xamarin.Forms
        {
                public static readonly BindableProperty TextColorProperty = TextElement.TextColorProperty;
 
-               public static readonly BindableProperty CharacterSpacingProperty = TextElement.CharacterSpacingProperty;
-
                public static readonly BindableProperty TitleProperty =
                        BindableProperty.Create(nameof(Title), typeof(string), typeof(Picker), default(string));
 
@@ -287,7 +285,6 @@ namespace Xamarin.Forms
 
                void ITextElement.OnCharacterSpacingPropertyChanged(double oldValue, double newValue)
                {
-                       InvalidateMeasure();
                }
 
        }
index ad0283e..7d62dfd 100644 (file)
@@ -43,7 +43,6 @@ using Xamarin.Forms.StyleSheets;
 [assembly: StyleProperty("background-image", typeof(Page), nameof(Page.BackgroundImageSourceProperty))]
 [assembly: StyleProperty("border-color", typeof(IBorderElement), nameof(BorderElement.BorderColorProperty))]
 [assembly: StyleProperty("border-radius", typeof(ICornerElement), nameof(CornerElement.CornerRadiusProperty))]
-[assembly: StyleProperty("border-radius", typeof(Button), nameof(Button.CornerRadiusProperty))]
 [assembly: StyleProperty("border-radius", typeof(Frame), nameof(Frame.CornerRadiusProperty))]
 [assembly: StyleProperty("border-radius", typeof(ImageButton), nameof(BorderElement.CornerRadiusProperty))]
 [assembly: StyleProperty("border-width", typeof(IBorderElement), nameof(BorderElement.BorderWidthProperty))]
@@ -62,7 +61,6 @@ using Xamarin.Forms.StyleSheets;
 [assembly: StyleProperty("margin-top", typeof(View), nameof(View.MarginTopProperty))]
 [assembly: StyleProperty("margin-right", typeof(View), nameof(View.MarginRightProperty))]
 [assembly: StyleProperty("margin-bottom", typeof(View), nameof(View.MarginBottomProperty))]
-[assembly: StyleProperty("max-lines", typeof(Label), nameof(Label.MaxLinesProperty))]
 [assembly: StyleProperty("min-height", typeof(VisualElement), nameof(VisualElement.MinimumHeightRequestProperty))]
 [assembly: StyleProperty("min-width", typeof(VisualElement), nameof(VisualElement.MinimumWidthRequestProperty))]
 [assembly: StyleProperty("opacity", typeof(VisualElement), nameof(VisualElement.OpacityProperty))]
@@ -111,7 +109,6 @@ using Xamarin.Forms.StyleSheets;
 [assembly: StyleProperty("-xf-orientation", typeof(StackLayout), nameof(StackLayout.OrientationProperty))]
 [assembly: StyleProperty("-xf-visual", typeof(VisualElement), nameof(VisualElement.VisualProperty))]
 [assembly: StyleProperty("-xf-vertical-text-alignment", typeof(Label), nameof(TextAlignmentElement.VerticalTextAlignmentProperty))]
-[assembly: StyleProperty("-xf-thumb-color", typeof(Switch), nameof(Switch.ThumbColorProperty))]
 
 //shell
 [assembly: StyleProperty("-xf-flyout-background", typeof(Shell), nameof(Shell.FlyoutBackgroundColorProperty))]
index 0550c81..554b1a7 100644 (file)
@@ -14,7 +14,6 @@ namespace Xamarin.Forms
 
                public RefreshView()
                {
-                       IsClippedToBounds = true;
                        VerticalOptions = LayoutOptions.FillAndExpand;
                        HorizontalOptions = LayoutOptions.FillAndExpand;
 
index 43dcad8..efd50b3 100644 (file)
@@ -33,8 +33,6 @@ namespace Xamarin.Forms
 
                public new static readonly BindableProperty TextColorProperty = InputView.TextColorProperty;
 
-               public new static readonly BindableProperty CharacterSpacingProperty = InputView.CharacterSpacingProperty;
-
                readonly Lazy<PlatformConfigurationRegistry<SearchBar>> _platformConfigurationRegistry;
 
                public Color CancelButtonColor
index 0ef7ae2..e9faf22 100644 (file)
@@ -47,12 +47,6 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty ThumbColorProperty = BindableProperty.Create(nameof(ThumbColor), typeof(Color), typeof(Slider), Color.Default);
 
-               public static readonly BindableProperty ThumbImageSourceProperty = BindableProperty.Create(nameof(ThumbImageSource), typeof(ImageSource), typeof(Slider), default(ImageSource));
-
-               [Obsolete("ThumbImageProperty is obsolete as of 4.0.0. Please use ThumbImageSourceProperty instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public static readonly BindableProperty ThumbImageProperty = ThumbImageSourceProperty;
-
                public static readonly BindableProperty DragStartedCommandProperty = BindableProperty.Create(nameof(DragStartedCommand), typeof(ICommand), typeof(Slider), default(ICommand));
 
                public static readonly BindableProperty DragCompletedCommandProperty = BindableProperty.Create(nameof(DragCompletedCommand), typeof(ICommand), typeof(Slider), default(ICommand));
@@ -100,20 +94,6 @@ namespace Xamarin.Forms
                        set { SetValue(ThumbColorProperty, value); }
                }
 
-               public ImageSource ThumbImageSource
-               {
-                       get { return (ImageSource)GetValue(ThumbImageSourceProperty); }
-                       set { SetValue(ThumbImageSourceProperty, value); }
-               }
-
-               [Obsolete("ThumbImage is obsolete as of 4.0.0. Please use ThumbImageSource instead.")]
-               [EditorBrowsable(EditorBrowsableState.Never)]
-               public FileImageSource ThumbImage
-               {
-                       get { return GetValue(ThumbImageProperty) as FileImageSource; }
-                       set { SetValue(ThumbImageProperty, value); }
-               }
-
                public ICommand DragStartedCommand
                {
                        get { return (ICommand)GetValue(DragStartedCommandProperty); }
index 3eee876..3008deb 100644 (file)
@@ -15,20 +15,12 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty OnColorProperty = BindableProperty.Create(nameof(OnColor), typeof(Color), typeof(Switch), Color.Default);
 
-               public static readonly BindableProperty ThumbColorProperty = BindableProperty.Create(nameof(ThumbColor), typeof(Color), typeof(Switch), Color.Default);
-
                public Color OnColor
                {
                        get { return (Color)GetValue(OnColorProperty); }
                        set { SetValue(OnColorProperty, value); }
                }
 
-               public Color ThumbColor
-               {
-                       get { return (Color)GetValue(ThumbColorProperty); }
-                       set { SetValue(ThumbColorProperty, value); }
-               }
-
                readonly Lazy<PlatformConfigurationRegistry<Switch>> _platformConfigurationRegistry;
 
                public Switch()
index 108b7fd..90a0d17 100644 (file)
@@ -11,8 +11,6 @@ namespace Xamarin.Forms
 
                public static readonly BindableProperty TextColorProperty = TextElement.TextColorProperty;
 
-               public static readonly BindableProperty CharacterSpacingProperty = TextElement.CharacterSpacingProperty;
-
                public static readonly BindableProperty TimeProperty = BindableProperty.Create(nameof(Time), typeof(TimeSpan), typeof(TimePicker), new TimeSpan(0), BindingMode.TwoWay, (bindable, value) =>
                {
                        var time = (TimeSpan)value;
@@ -44,11 +42,7 @@ namespace Xamarin.Forms
                        set { SetValue(TextElement.TextColorProperty, value); }
                }
 
-               public double CharacterSpacing
-               {
-                       get { return (double)GetValue(TextElement.CharacterSpacingProperty); }
-                       set { SetValue(TextElement.CharacterSpacingProperty, value); }
-               }
+               public double CharacterSpacing { get; set; }
 
                public TimeSpan Time
                {
@@ -101,7 +95,6 @@ namespace Xamarin.Forms
 
                void ITextElement.OnCharacterSpacingPropertyChanged(double oldValue, double newValue)
                {
-                       InvalidateMeasure();
                }
 
        }
index 2ad180c..d42a967 100644 (file)
@@ -721,7 +721,10 @@ namespace Xamarin.Forms
                                typeof(Layout),
                                typeof(Span),
                                typeof(TapGestureRecognizer),
-                               typeof(PropertyCondition)
+                               typeof(PropertyCondition),
+                               typeof(RefreshView),
+                               typeof(StructuredItemsView),
+                               typeof(SearchHandler),
                        };
 
                        foreach (var type in types)
index f6970c0..cd1bb61 100644 (file)
@@ -15,9 +15,6 @@ namespace Xamarin.Forms.Platform.Tizen
                        RegisterPropertyHandler(Button.FontAttributesProperty, UpdateFontAttributes);
                        RegisterPropertyHandler(Button.TextColorProperty, UpdateTextColor);
                        RegisterPropertyHandler(Button.ImageSourceProperty, UpdateBitmap);
-                       RegisterPropertyHandler(Button.BorderColorProperty, UpdateBorder);
-                       RegisterPropertyHandler(Button.CornerRadiusProperty, UpdateBorder);
-                       RegisterPropertyHandler(Button.BorderWidthProperty, UpdateBorder);
                }
 
                protected override void OnElementChanged(ElementChangedEventArgs<Button> e)
@@ -148,13 +145,5 @@ namespace Xamarin.Forms.Platform.Tizen
                                }
                        }                       
                }
-
-               void UpdateBorder()
-               {
-                       /* The simpler way is to create some specialized theme for button in
-                        * tizen-theme
-                        */
-                       // TODO: implement border handling
-               }
        }
 }