resource-directory: Check links before free

In case if pointer has not been assigned

This is also suppressing a valgrind warning
when running test resource/csdk/stack/test/stacktests:

  2,208 bytes in 1 blocks \
  are possibly lost in loss record 0 if 0

Bug: https://jira.iotivity.org/browse/IOT-2645
Change-Id: Ifd44172a1f7755ec253748f6f02fbfd1dcacdd39
Origin: https://gerrit.iotivity.org/gerrit/#/c/22107/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/22107
Tested-by: jenkins-iotivity <jenkins@iotivity.org>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Mats Wichmann <mats@linux.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
(cherry picked from commit 2c926be5e04dd982316c05c461c9a95fd0beae9a)

diff --git a/resource/csdk/resource-directory/src/rd_client.c b/resource/csdk/resource-directory/src/rd_client.c
index 0a60445a58dad6e849ed814cd8728cb7697ba292..a7d9dcb9fd6b09d5d69b549119e8f8af1ddd3800 100644 (file)
--- a/resource/csdk/resource-directory/src/rd_client.c
+++ b/resource/csdk/resource-directory/src/rd_client.c
@@ -109,11 +109,14 @@ OCStackApplicationResult RDPublishCallback(void *ctx,
     }
 
 exit:
-    for (size_t i = 0; i < dimensions[0]; i++)
+    if (links)
     {
-        OCRepPayloadDestroy(links[i]);
+        for (size_t i = 0; i < dimensions[0]; i++)
+        {
+            OCRepPayloadDestroy(links[i]);
+        }
+        OICFree(links);
     }
-    OICFree(links);
     return cbData->cb(cbData->context, handle, clientResponse);
 }