staging/lustre: Fix unnecessary parentheses around variables

This patch fixes all checkpatch occurences of
"CHECK: Unnecessary parentheses around xxx"
in Lustre code.

Signed-off-by: Emoly Liu <emoly.liu@intel.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
index 52cd585..229aecb 100644 (file)
--- a/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
+++ b/drivers/staging/lustre/lustre/include/lustre/lustre_user.h
@@ -995,7 +995,7 @@ struct hsm_user_request {
 /** Return pointer to data field in a hsm user request */
 static inline void *hur_data(struct hsm_user_request *hur)
 {
-       return &(hur->hur_user_item[hur->hur_request.hr_itemcount]);
+       return &hur->hur_user_item[hur->hur_request.hr_itemcount];
 }
 
 /**

diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lov/lov_obd.c
index d904f44..49b1050 100644 (file)
--- a/drivers/staging/lustre/lustre/lov/lov_obd.c
+++ b/drivers/staging/lustre/lustre/lov/lov_obd.c
@@ -941,7 +941,7 @@ int lov_process_config_base(struct obd_device *obd, struct lustre_cfg *lcfg,
        }
        case LCFG_PARAM: {
                struct lprocfs_static_vars lvars = { NULL };
-               struct lov_desc *desc = &(obd->u.lov.desc);
+               struct lov_desc *desc = &obd->u.lov.desc;
 
                if (!desc) {
                        rc = -EINVAL;
@@ -1461,7 +1461,7 @@ static int lov_iocontrol(unsigned int cmd, struct obd_export *exp, int len,
                }
 
                desc = (struct lov_desc *)data->ioc_inlbuf1;
-               memcpy(desc, &(lov->desc), sizeof(*desc));
+               memcpy(desc, &lov->desc, sizeof(*desc));
 
                uuidp = (struct obd_uuid *)data->ioc_inlbuf2;
                genp = (__u32 *)data->ioc_inlbuf3;

diff --git a/drivers/staging/lustre/lustre/lov/lov_pool.c b/drivers/staging/lustre/lustre/lov/lov_pool.c
index 4c2d217..8bfa101 100644 (file)
--- a/drivers/staging/lustre/lustre/lov/lov_pool.c
+++ b/drivers/staging/lustre/lustre/lov/lov_pool.c
@@ -61,7 +61,7 @@ void lov_pool_putref(struct pool_desc *pool)
                LASSERT(hlist_unhashed(&pool->pool_hash));
                LASSERT(list_empty(&pool->pool_list));
                LASSERT(!pool->pool_debugfs_entry);
-               lov_ost_pool_free(&(pool->pool_obds));
+               lov_ost_pool_free(&pool->pool_obds);
                kfree(pool);
        }
 }
@@ -260,7 +260,7 @@ static int pool_proc_show(struct seq_file *s, void *v)
        tgt = pool_tgt(iter->pool, iter->idx);
        up_read(&pool_tgt_rw_sem(iter->pool));
        if (tgt)
-               seq_printf(s, "%s\n", obd_uuid2str(&(tgt->ltd_uuid)));
+               seq_printf(s, "%s\n", obd_uuid2str(&tgt->ltd_uuid));
 
        return 0;
 }
@@ -400,7 +400,7 @@ int lov_pool_new(struct obd_device *obd, char *poolname)
        struct pool_desc *new_pool;
        int rc;
 
-       lov = &(obd->u.lov);
+       lov = &obd->u.lov;
 
        if (strlen(poolname) > LOV_MAXPOOLNAME)
                return -ENAMETOOLONG;
@@ -471,7 +471,7 @@ int lov_pool_del(struct obd_device *obd, char *poolname)
        struct lov_obd *lov;
        struct pool_desc *pool;
 
-       lov = &(obd->u.lov);
+       lov = &obd->u.lov;
 
        /* lookup and kill hash reference */
        pool = cfs_hash_del_key(lov->lov_pools_hash_body, poolname);
@@ -503,7 +503,7 @@ int lov_pool_add(struct obd_device *obd, char *poolname, char *ostname)
        unsigned int lov_idx;
        int rc;
 
-       lov = &(obd->u.lov);
+       lov = &obd->u.lov;
 
        pool = cfs_hash_lookup(lov->lov_pools_hash_body, poolname);
        if (!pool)
@@ -517,7 +517,7 @@ int lov_pool_add(struct obd_device *obd, char *poolname, char *ostname)
                if (!lov->lov_tgts[lov_idx])
                        continue;
                if (obd_uuid_equals(&ost_uuid,
-                                   &(lov->lov_tgts[lov_idx]->ltd_uuid)))
+                                   &lov->lov_tgts[lov_idx]->ltd_uuid))
                        break;
        }
        /* test if ost found in lov */
@@ -547,7 +547,7 @@ int lov_pool_remove(struct obd_device *obd, char *poolname, char *ostname)
        unsigned int lov_idx;
        int rc = 0;
 
-       lov = &(obd->u.lov);
+       lov = &obd->u.lov;
 
        pool = cfs_hash_lookup(lov->lov_pools_hash_body, poolname);
        if (!pool)
@@ -562,7 +562,7 @@ int lov_pool_remove(struct obd_device *obd, char *poolname, char *ostname)
                        continue;
 
                if (obd_uuid_equals(&ost_uuid,
-                                   &(lov->lov_tgts[lov_idx]->ltd_uuid)))
+                                   &lov->lov_tgts[lov_idx]->ltd_uuid))
                        break;
        }
 

diff --git a/drivers/staging/lustre/lustre/obdclass/genops.c b/drivers/staging/lustre/lustre/obdclass/genops.c
index a739eb1..6356870 100644 (file)
--- a/drivers/staging/lustre/lustre/obdclass/genops.c
+++ b/drivers/staging/lustre/lustre/obdclass/genops.c
@@ -166,10 +166,10 @@ int class_register_type(struct obd_ops *dt_ops, struct md_ops *md_ops,
            !type->typ_name)
                goto failed;
 
-       *(type->typ_dt_ops) = *dt_ops;
+       *type->typ_dt_ops = *dt_ops;
        /* md_ops is optional */
        if (md_ops)
-               *(type->typ_md_ops) = *md_ops;
+               *type->typ_md_ops = *md_ops;
        strcpy(type->typ_name, name);
        spin_lock_init(&type->obd_type_lock);
 

diff --git a/drivers/staging/lustre/lustre/obdclass/llog.c b/drivers/staging/lustre/lustre/obdclass/llog.c
index 1784ca0..8f06141 100644 (file)
--- a/drivers/staging/lustre/lustre/obdclass/llog.c
+++ b/drivers/staging/lustre/lustre/obdclass/llog.c
@@ -80,7 +80,7 @@ static void llog_free_handle(struct llog_handle *loghandle)
                LASSERT(list_empty(&loghandle->u.phd.phd_entry));
        else if (loghandle->lgh_hdr->llh_flags & LLOG_F_IS_CAT)
                LASSERT(list_empty(&loghandle->u.chd.chd_head));
-       LASSERT(sizeof(*(loghandle->lgh_hdr)) == LLOG_CHUNK_SIZE);
+       LASSERT(sizeof(*loghandle->lgh_hdr) == LLOG_CHUNK_SIZE);
        kfree(loghandle->lgh_hdr);
 out:
        kfree(loghandle);

diff --git a/drivers/staging/lustre/lustre/obdclass/lustre_handles.c b/drivers/staging/lustre/lustre/obdclass/lustre_handles.c
index 7ca68ae..8faa318 100644 (file)
--- a/drivers/staging/lustre/lustre/obdclass/lustre_handles.c
+++ b/drivers/staging/lustre/lustre/obdclass/lustre_handles.c
@@ -214,7 +214,7 @@ static int cleanup_all_handles(void)
                struct portals_handle *h;
 
                spin_lock(&handle_hash[i].lock);
-               list_for_each_entry_rcu(h, &(handle_hash[i].head), h_link) {
+               list_for_each_entry_rcu(h, &handle_hash[i].head, h_link) {
                        CERROR("force clean handle %#llx addr %p ops %p\n",
                               h->h_cookie, h, h->h_ops);
 

diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c b/drivers/staging/lustre/lustre/obdclass/obd_config.c
index 01034b5..220fda7 100644 (file)
--- a/drivers/staging/lustre/lustre/obdclass/obd_config.c
+++ b/drivers/staging/lustre/lustre/obdclass/obd_config.c
@@ -1013,7 +1013,7 @@ int class_process_proc_param(char *prefix, struct lprocfs_vars *lvars,
 
                                        oldfs = get_fs();
                                        set_fs(KERNEL_DS);
-                                       rc = (var->fops->write)(&fakefile, sval,
+                                       rc = var->fops->write(&fakefile, sval,
                                                                vallen, NULL);
                                        set_fs(oldfs);
                                }

diff --git a/drivers/staging/lustre/lustre/obdclass/obd_mount.c b/drivers/staging/lustre/lustre/obdclass/obd_mount.c
index 595ea1f..b838194 100644 (file)
--- a/drivers/staging/lustre/lustre/obdclass/obd_mount.c
+++ b/drivers/staging/lustre/lustre/obdclass/obd_mount.c
@@ -394,7 +394,7 @@ int lustre_start_mgc(struct super_block *sb)
            lsi->lsi_lmd->lmd_flags & LMD_FLG_NOIR)
                data->ocd_connect_flags &= ~OBD_CONNECT_IMP_RECOV;
        data->ocd_version = LUSTRE_VERSION_CODE;
-       rc = obd_connect(NULL, &exp, obd, &(obd->obd_uuid), data, NULL);
+       rc = obd_connect(NULL, &exp, obd, &obd->obd_uuid, data, NULL);
        if (rc) {
                CERROR("connect failed %d\n", rc);
                goto out;

diff --git a/drivers/staging/lustre/lustre/osc/osc_request.c b/drivers/staging/lustre/lustre/osc/osc_request.c
index 2a4056a..3709440 100644 (file)
--- a/drivers/staging/lustre/lustre/osc/osc_request.c
+++ b/drivers/staging/lustre/lustre/osc/osc_request.c
@@ -2633,7 +2633,7 @@ static int osc_getstripe(struct lov_stripe_md *lsm,
                        lmm_objects =
                            &(((struct lov_user_md_v1 *)lumk)->lmm_objects[0]);
                else
-                       lmm_objects = &(lumk->lmm_objects[0]);
+                       lmm_objects = &lumk->lmm_objects[0];
                lmm_objects->l_ost_oi = lsm->lsm_oi;
        } else {
                lum_size = lov_mds_md_size(0, lum.lmm_magic);

diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
index 465698b..9c03a9a 100644 (file)
--- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
@@ -1978,9 +1978,9 @@ void lustre_swab_lov_user_md_objects(struct lov_user_ost_data *lod,
        int i;
 
        for (i = 0; i < stripe_count; i++) {
-               lustre_swab_ost_id(&(lod[i].l_ost_oi));
-               __swab32s(&(lod[i].l_ost_gen));
-               __swab32s(&(lod[i].l_ost_idx));
+               lustre_swab_ost_id(&lod[i].l_ost_oi);
+               __swab32s(&lod[i].l_ost_gen);
+               __swab32s(&lod[i].l_ost_idx);
        }
 }
 EXPORT_SYMBOL(lustre_swab_lov_user_md_objects);