Fix for 1> "unexpected marker appears(display error) while write silotan in URL bar"
authorbhargavi.k <bhargavi.k@samsung.com>
Thu, 26 Sep 2013 11:54:55 +0000 (17:24 +0530)
committerbhargavi.k <bhargavi.k@samsung.com>
Mon, 30 Sep 2013 07:41:17 +0000 (13:11 +0530)
        2> "unwanted marker icon apperaing in improper position after tap on sign in in outlook.com"

[Title]  Fix for "unexpected marker appears(display error) while write silotan in URL bar"
[Issue#] N_SE-52817 , N_SE-52754
[Problem] text selection handlers are displaying wrong
[Cause]   on page load due to autofcous , handlers of selection is displayed.
[Solution] Added a check for pageloading, during pageload handlers are not drawn.

Change-Id: I27944293ff58f9f03b777982c0ec0e097ee0577c

Source/WebKit2/UIProcess/API/efl/tizen/TextSelection.cpp

index f9a3061..3680991 100755 (executable)
@@ -130,12 +130,16 @@ void TextSelection::update()
                 showContextMenu();
             }
         }
-    }else {
-        if (editorState.selectionIsRange) {
-            setIsTextSelectionMode(true);
-            updateHandlers();
-            showContextMenu();
-        }
+        return;
+    }
+    // Auto selection happened from the JS through Editor command and update called from
+    // WebPageProxy::editorStateChanged(), so need to update the selection handler and context
+    // menu because focused node is currently active.
+    if (editorState.isContentEditable && editorState.selectionIsRange && !editorState.selectionRect.isEmpty() && m_viewImpl->page()
+        && m_viewImpl->page()->isLoadingFinished()) {
+        setIsTextSelectionMode(true);
+        updateHandlers();
+        showContextMenu();
     }
 }