[CMake] Don't look for terminfo libs when LLVM_ENABLE_TERMINFO=OFF
authorPetr Hosek <phosek@google.com>
Wed, 19 Aug 2020 17:30:32 +0000 (10:30 -0700)
committerPetr Hosek <phosek@google.com>
Wed, 19 Aug 2020 17:31:42 +0000 (10:31 -0700)
D85820 introduced a bug where LLVM_ENABLE_TERMINFO was set to true when
the library was found, even when the user had set
-DLLVM_ENABLE_TERMINFO=OFF.

Patch By: haampie

Differential Revision: https://reviews.llvm.org/D86173

compiler-rt/cmake/config-ix.cmake
llvm/cmake/config-ix.cmake

index c9d0da2..1428a51 100644 (file)
@@ -138,7 +138,9 @@ if(LLVM_ENABLE_TERMINFO STREQUAL FORCE_ON)
 else()
   set(MAYBE_REQUIRED)
 endif()
-find_library(COMPILER_RT_TERMINFO_LIB NAMES terminfo tinfo curses ncurses ncursesw ${MAYBE_REQUIRED})
+if(LLVM_ENABLE_TERMINFO)
+  find_library(COMPILER_RT_TERMINFO_LIB NAMES terminfo tinfo curses ncurses ncursesw ${MAYBE_REQUIRED})
+endif()
 if(COMPILER_RT_TERMINFO_LIB)
   set(LLVM_ENABLE_TERMINFO 1)
 else()
index 67e2eb1..6e8f476 100644 (file)
@@ -152,7 +152,9 @@ if(NOT LLVM_USE_SANITIZER MATCHES "Memory.*")
     else()
       set(MAYBE_REQUIRED)
     endif()
-    find_library(TERMINFO_LIB NAMES terminfo tinfo curses ncurses ncursesw ${MAYBE_REQUIRED})
+    if(LLVM_ENABLE_TERMINFO)
+      find_library(TERMINFO_LIB NAMES terminfo tinfo curses ncurses ncursesw ${MAYBE_REQUIRED})
+    endif()
     if(TERMINFO_LIB)
       set(LLVM_ENABLE_TERMINFO 1)
     else()