hwmon: (bt1-pvt) Remove redundant error printing in pvt_request_regs()
authorZhen Lei <thunder.leizhen@huawei.com>
Tue, 11 May 2021 09:18:43 +0000 (17:18 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Thu, 17 Jun 2021 11:21:45 +0000 (04:21 -0700)
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.

Therefore, remove the error printing here to simplify code and reduce the
binary size.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210511091843.4561-1-thunder.leizhen@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/bt1-pvt.c

index 3e1d565..74ce521 100644 (file)
@@ -924,10 +924,8 @@ static int pvt_request_regs(struct pvt_hwmon *pvt)
        }
 
        pvt->regs = devm_ioremap_resource(pvt->dev, res);
-       if (IS_ERR(pvt->regs)) {
-               dev_err(pvt->dev, "Couldn't map PVT registers\n");
+       if (IS_ERR(pvt->regs))
                return PTR_ERR(pvt->regs);
-       }
 
        return 0;
 }