media: ngene: avoid unused variable warning
authorArnd Bergmann <arnd@arndb.de>
Tue, 13 Mar 2018 13:06:03 +0000 (09:06 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Thu, 22 Mar 2018 10:17:40 +0000 (06:17 -0400)
The newly added pdev variable is only used in an #ifdef, causing a
build warning without CONFIG_PCI_MSI, unless we move the declaration
inside the same #ifdef:

drivers/media/pci/ngene/ngene-core.c: In function 'ngene_start':
drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable 'pdev' [-Werror=unused-variable]

Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk() to dev_*() macros")

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/ngene/ngene-core.c

index 3b9a1bf..25f1683 100644 (file)
@@ -1325,7 +1325,6 @@ static int ngene_buffer_config(struct ngene *dev)
 
 static int ngene_start(struct ngene *dev)
 {
-       struct device *pdev = &dev->pci_dev->dev;
        int stat;
        int i;
 
@@ -1359,6 +1358,7 @@ static int ngene_start(struct ngene *dev)
 #ifdef CONFIG_PCI_MSI
        /* enable MSI if kernel and card support it */
        if (pci_msi_enabled() && dev->card_info->msi_supported) {
+               struct device *pdev = &dev->pci_dev->dev;
                unsigned long flags;
 
                ngwritel(0, NGENE_INT_ENABLE);