scsi: qla2xxx: Fix PRLI state check
authorQuinn Tran <quinn.tran@cavium.com>
Mon, 4 Dec 2017 22:45:08 +0000 (14:45 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Mar 2018 09:54:26 +0000 (10:54 +0100)
commit 23c645595dab7b414f23639d0a428a07515807df upstream.

Get Port Database MBX cmd is to validate current Login state upon PRLI
completion. Current code looks at the last login state for re-validation
which was incorrect. This patch removed incorrect state check.

Fixes: 15f30a5752287 ("qla2xxx: Use IOCB interface to submit non-critical MBX.")
Cc: <stable@vger.kernel.org> # 4.10+
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/qla2xxx/qla_mbx.c

index 99502fa..2d909e1 100644 (file)
@@ -6078,8 +6078,7 @@ int __qla24xx_parse_gpdb(struct scsi_qla_host *vha, fc_port_t *fcport,
        }
 
        /* Check for logged in state. */
-       if (current_login_state != PDS_PRLI_COMPLETE &&
-           last_login_state != PDS_PRLI_COMPLETE) {
+       if (current_login_state != PDS_PRLI_COMPLETE) {
                ql_dbg(ql_dbg_mbx, vha, 0x119a,
                    "Unable to verify login-state (%x/%x) for loop_id %x.\n",
                    current_login_state, last_login_state, fcport->loop_id);