wifi: libertas: if_usb: don't call kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Dec 2022 15:00:06 +0000 (23:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:32:50 +0000 (09:32 +0100)
[ Upstream commit 3968e81ba644f10a7d45bae2539560db9edac501 ]

It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile
tested only.

Fixes: a3128feef6d5 ("libertas: use irqsave() in USB's complete callback")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221207150008.111743-3-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/libertas/if_usb.c

index 32fdc41..2240b4d 100644 (file)
@@ -637,7 +637,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff,
        priv->resp_len[i] = (recvlength - MESSAGE_HEADER_LEN);
        memcpy(priv->resp_buf[i], recvbuff + MESSAGE_HEADER_LEN,
                priv->resp_len[i]);
-       kfree_skb(skb);
+       dev_kfree_skb_irq(skb);
        lbs_notify_command_response(priv, i);
 
        spin_unlock_irqrestore(&priv->driver_lock, flags);