i8259: Do not update IRQ output after spurious pic_poll_read
authorJan Kiszka <jan.kiszka@siemens.com>
Fri, 7 Oct 2011 07:19:42 +0000 (09:19 +0200)
committerBlue Swirl <blauwirbel@gmail.com>
Sun, 16 Oct 2011 11:11:04 +0000 (11:11 +0000)
If pic_poll_read finds no pending IRQ and return a spurious one instead,
no PIC state is changed, thus we do not need to call pic_update_irq.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
hw/i8259.c

index 65123bd2dc733df70847dfc0bd06b16001f4b457..cddd3c769e6e152aa9028fa4e5f805cfcbaa58b8 100644 (file)
@@ -393,7 +393,6 @@ static uint32_t pic_poll_read(PicState *s)
             pic_update_irq(s->pics_state);
     } else {
         ret = 0x07;
-        pic_update_irq(s->pics_state);
     }
 
     return ret;