drm: Fix framebuffer leak
authorNikhil Mahale <nmahale@nvidia.com>
Wed, 9 Aug 2017 03:53:01 +0000 (09:23 +0530)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 14 Aug 2017 13:30:33 +0000 (15:30 +0200)
Do not leak framebuffer if client provided crtc id found invalid.

Signed-off-by: Nikhil Mahale <nmahale@nvidia.com>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1502250781-5779-1-git-send-email-nmahale@nvidia.com
drivers/gpu/drm/drm_plane.c

index 5dc8c43..e40c12f 100644 (file)
@@ -601,6 +601,7 @@ int drm_mode_setplane(struct drm_device *dev, void *data,
 
                crtc = drm_crtc_find(dev, plane_req->crtc_id);
                if (!crtc) {
+                       drm_framebuffer_put(fb);
                        DRM_DEBUG_KMS("Unknown crtc ID %d\n",
                                      plane_req->crtc_id);
                        return -ENOENT;