intel: Add TODO about removal of 2Mb alignment in i915
authorJosé Roberto de Souza <jose.souza@intel.com>
Thu, 16 Mar 2023 19:09:56 +0000 (12:09 -0700)
committerMarge Bot <emma+marge@anholt.net>
Mon, 20 Mar 2023 17:18:04 +0000 (17:18 +0000)
Xe kmd don't suffer this yet because it still lacks MTL support.

Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21972>

src/intel/dev/i915/intel_device_info.c

index 982c81e..995cf6f 100644 (file)
@@ -610,6 +610,10 @@ bool intel_device_info_i915_get_info_from_fd(int fd, struct intel_device_info *d
    if (getparam(fd, I915_PARAM_HAS_CONTEXT_ISOLATION, &val))
       devinfo->has_context_isolation = val;
 
+   /* TODO: i915 don't require anymore the 2Mb alignment for gfx 12.5 and
+    * newer but using 64k brings some issues like unaligned offsets with
+    * aux map aligned to 1Mb in MTL.
+    */
    if (devinfo->verx10 >= 125)
       devinfo->mem_alignment = 2 * 1024 * 1024;
    else if (devinfo->has_local_mem)