projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0b05327
)
mfd: qcom-pm8xxx: Remove set but unused variable 'rev'
author
Jiapeng Chong
<jiapeng.chong@linux.alibaba.com>
Tue, 27 Dec 2022 08:19:21 +0000
(16:19 +0800)
committer
Lee Jones
<lee@kernel.org>
Wed, 22 Feb 2023 08:25:52 +0000
(08:25 +0000)
Variable rev is not effectively used in the function, so delete it.
drivers/mfd/qcom-pm8xxx.c:513:6: warning: variable 'rev' set but not used.
Link:
https://bugzilla.openanolis.cn/show_bug.cgi?id=3558
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link:
https://lore.kernel.org/r/20221227081921.56448-1-jiapeng.chong@linux.alibaba.com
drivers/mfd/qcom-pm8xxx.c
patch
|
blob
|
history
diff --git
a/drivers/mfd/qcom-pm8xxx.c
b/drivers/mfd/qcom-pm8xxx.c
index 601106580e2e56ee6507aceaf91f69fb58396a8d..9a948df8c28dcf12f378922a2b29697d69d19039 100644
(file)
--- a/
drivers/mfd/qcom-pm8xxx.c
+++ b/
drivers/mfd/qcom-pm8xxx.c
@@
-510,7
+510,6
@@
static int pm8xxx_probe(struct platform_device *pdev)
struct regmap *regmap;
int irq, rc;
unsigned int val;
- u32 rev;
struct pm_irq_chip *chip;
data = of_device_get_match_data(&pdev->dev);
@@
-535,7
+534,6
@@
static int pm8xxx_probe(struct platform_device *pdev)
return rc;
}
pr_info("PMIC revision 1: %02X\n", val);
- rev = val;
/* Read PMIC chip revision 2 */
rc = regmap_read(regmap, REG_HWREV_2, &val);
@@
-545,7
+543,6
@@
static int pm8xxx_probe(struct platform_device *pdev)
return rc;
}
pr_info("PMIC revision 2: %02X\n", val);
- rev |= val << BITS_PER_BYTE;
chip = devm_kzalloc(&pdev->dev,
struct_size(chip, config, data->num_irqs),