Add dialog.showErrorBox API
authorCheng Zhao <zcbenz@gmail.com>
Wed, 5 Nov 2014 08:04:39 +0000 (16:04 +0800)
committerCheng Zhao <zcbenz@gmail.com>
Wed, 5 Nov 2014 08:04:39 +0000 (16:04 +0800)
atom/browser/api/atom_api_dialog.cc
atom/browser/api/lib/dialog.coffee
atom/browser/ui/message_box.h

index 3c4d028..975c309 100644 (file)
@@ -103,6 +103,7 @@ void Initialize(v8::Handle<v8::Object> exports, v8::Handle<v8::Value> unused,
                 v8::Handle<v8::Context> context, void* priv) {
   mate::Dictionary dict(context->GetIsolate(), exports);
   dict.SetMethod("showMessageBox", &ShowMessageBox);
+  dict.SetMethod("showErrorBox", &atom::ShowErrorBox);
   dict.SetMethod("showOpenDialog", &ShowOpenDialog);
   dict.SetMethod("showSaveDialog", &ShowSaveDialog);
 }
index 640db08..0cdd3c3 100644 (file)
@@ -93,5 +93,8 @@ module.exports =
                            window,
                            callback
 
+  showErrorBox: (args...) ->
+    binding.showErrorBox args...
+
 # Mark standard asynchronous functions.
 v8Util.setHiddenValue f, 'asynchronous', true for k, f of module.exports
index c3d2c5d..bdaa31e 100644 (file)
@@ -9,6 +9,7 @@
 #include <vector>
 
 #include "base/callback_forward.h"
+#include "base/strings/string16.h"
 
 namespace atom {
 
@@ -37,6 +38,10 @@ void ShowMessageBox(NativeWindow* parent_window,
                     const std::string& detail,
                     const MessageBoxCallback& callback);
 
+// Like ShowMessageBox with simplest settings, but safe to call at very early
+// stage of application.
+void ShowErrorBox(const base::string16& title, const base::string16& content);
+
 }  // namespace atom
 
 #endif  // ATOM_BROWSER_UI_MESSAGE_BOX_H_