videorate: remove property-value quotes
authorJames Hilliard <james.hilliard1@gmail.com>
Thu, 16 Jun 2022 10:19:17 +0000 (10:19 +0000)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Wed, 29 Jun 2022 00:36:17 +0000 (00:36 +0000)
Fixes warnings like:
Received a structure string that contains '="0.5"'. Reading as a gdouble value, rather than a string value. This is undesired behaviour, and with GStreamer 1.22  onward, this will be interpreted as a string value instead because it is wrapped in '"' quotes. If you want to guarantee this value is read as a string, before this change, use '=(string)"0.5"' instead. If you want to read in a gdouble value, leave its value unquoted.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2621>

subprojects/gst-plugins-base/tests/validate/videorate/change_rate_reverse_playback.validatetest
subprojects/gst-plugins-base/tests/validate/videorate/change_rate_while_playing.validatetest

index 1282820..e056eb4 100644 (file)
@@ -23,7 +23,7 @@ wait, on-clock=true
 
 # Set videorate.rate = 0.5 and add that info to the expecation files for better readability
 checkpoint, text="Setting videorate.rate=0.5"
-set-property, playback-time=99.0, target-element-name=videorate, property-name=rate, property-value="0.5" # playback-time=99.0 so that the action is executed asap but no on element addition
+set-property, playback-time=99.0, target-element-name=videorate, property-name=rate, property-value=0.5 # playback-time=99.0 so that the action is executed asap but no on element addition
 
 # Cranking 5 times, and let following buffer through
 crank-clock, repeat=5, expected-elapsed-time=0.1
@@ -32,14 +32,14 @@ check-position, expected-position=4.0 # seek.stop - (10*(1/10fps)) = 4.0s
 
 set-vars, rate=(string)0.1
 checkpoint, text="Setting videorate.rate=0.1"
-set-property, playback-time=99.0, target-element-name=videorate, property-name=rate, property-value="0.1"
+set-property, playback-time=99.0, target-element-name=videorate, property-name=rate, property-value=0.1
 crank-clock, repeat=20
 wait, on-clock=true
 check-position, expected-position=2.0 # seek.stop - (20*(1/10fps)) = 2.0s
 
 # Now setting rate=2.0
 checkpoint, text="Setting videorate.rate=2.0"
-set-property, playback-time=-1, target-element-name=videorate, property-name=rate, property-value="2.0"
+set-property, playback-time=-1, target-element-name=videorate, property-name=rate, property-value=2.0
 crank-clock, repeat=10
 wait, on-clock=true
 
index ff0763e..524557e 100644 (file)
@@ -18,21 +18,21 @@ check-position, expected-position=0.5
 wait, on-clock=true
 
 checkpoint, text="Setting videorate.rate=0.5"
-set-property, playback-time=0.5, target-element-name=videorate, property-name=rate, property-value="0.5"
+set-property, playback-time=0.5, target-element-name=videorate, property-name=rate, property-value=0.5
 crank-clock, repeat=5
 check-position, expected-position=1.0
 
 wait, on-clock=true
 
 checkpoint, text="Setting videorate.rate=0.1"
-set-property, playback-time=1.0, target-element-name=videorate, property-name=rate, property-value="0.1"
+set-property, playback-time=1.0, target-element-name=videorate, property-name=rate, property-value=0.1
 crank-clock, repeat=20
 check-position, expected-position=3.0
 
 wait, on-clock=true
 
 checkpoint, text="Setting videorate.rate=2.0"
-set-property, playback-time=2.0, target-element-name=videorate, property-name=rate, property-value="2.0"
+set-property, playback-time=2.0, target-element-name=videorate, property-name=rate, property-value=2.0
 crank-clock, repeat=10
 check-position, expected-position=4.0