projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5f8d1e3
)
hwmon: (adt7475) Fix masking of hysteresis registers
author
Tony O'Brien
<tony.obrien@alliedtelesis.co.nz>
Wed, 22 Feb 2023 00:52:28 +0000
(13:52 +1300)
committer
Guenter Roeck
<linux@roeck-us.net>
Sun, 5 Mar 2023 23:08:06 +0000
(15:08 -0800)
The wrong bits are masked in the hysteresis register; indices 0 and 2
should zero bits [7:4] and preserve bits [3:0], and index 1 should zero
bits [3:0] and preserve bits [7:4].
Fixes:
1c301fc5394f
("hwmon: Add a driver for the ADT7475 hardware monitoring chip")
Signed-off-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz>
Link:
https://lore.kernel.org/r/20230222005228.158661-3-tony.obrien@alliedtelesis.co.nz
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/adt7475.c
patch
|
blob
|
history
diff --git
a/drivers/hwmon/adt7475.c
b/drivers/hwmon/adt7475.c
index
77222c3
..
6e4c92b
100644
(file)
--- a/
drivers/hwmon/adt7475.c
+++ b/
drivers/hwmon/adt7475.c
@@
-488,10
+488,10
@@
static ssize_t temp_store(struct device *dev, struct device_attribute *attr,
val = (temp - val) / 1000;
if (sattr->index != 1) {
- data->temp[HYSTERSIS][sattr->index] &= 0x
F0
;
+ data->temp[HYSTERSIS][sattr->index] &= 0x
0F
;
data->temp[HYSTERSIS][sattr->index] |= (val & 0xF) << 4;
} else {
- data->temp[HYSTERSIS][sattr->index] &= 0x
0F
;
+ data->temp[HYSTERSIS][sattr->index] &= 0x
F0
;
data->temp[HYSTERSIS][sattr->index] |= (val & 0xF);
}