crypto: starfive - Depend on AMBA_PL08X instead of selecting it
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 23 May 2023 02:33:38 +0000 (10:33 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 24 May 2023 04:57:21 +0000 (12:57 +0800)
A platform option like AMBA should never be selected by a driver.
Use a dependency instead.

Also remove the depenency on DMADEVICES because the driver builds
just fine without it.  Instead add a dependency on HAS_DMA for dma
mapping support.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/starfive/Kconfig

index 908c162..59002ab 100644 (file)
@@ -4,14 +4,13 @@
 
 config CRYPTO_DEV_JH7110
        tristate "StarFive JH7110 cryptographic engine driver"
-       depends on (SOC_STARFIVE || COMPILE_TEST) && DMADEVICES
+       depends on SOC_STARFIVE || AMBA_PL08X || COMPILE_TEST
+       depends on HAS_DMA
        select CRYPTO_ENGINE
        select CRYPTO_HMAC
        select CRYPTO_SHA256
        select CRYPTO_SHA512
        select CRYPTO_SM3_GENERIC
-       select ARM_AMBA
-       select AMBA_PL08X
        help
          Support for StarFive JH7110 crypto hardware acceleration engine.
          This module provides acceleration for public key algo,