iio: health: afe4404: Remove duplicated error reporting in .remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 14 May 2022 13:04:32 +0000 (15:04 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 11 Jun 2022 13:35:26 +0000 (14:35 +0100)
Returning an error value in an i2c remove callback results in an error
message being emitted by the i2c core, but otherwise it doesn't make a
difference.

As afe4404_remove() already emits an error message on failure and the
additional error message by the i2c core doesn't add any useful
information, change the return value to zero to suppress this message.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220514130432.304674-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/health/afe4404.c

index aa9311e..1bb7de6 100644 (file)
@@ -591,10 +591,8 @@ static int afe4404_remove(struct i2c_client *client)
                iio_trigger_unregister(afe->trig);
 
        ret = regulator_disable(afe->regulator);
-       if (ret) {
+       if (ret)
                dev_err(afe->dev, "Unable to disable regulator\n");
-               return ret;
-       }
 
        return 0;
 }