Revert "devtmpfs: add debug info to handle()"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2023 07:59:22 +0000 (08:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Feb 2023 08:01:30 +0000 (09:01 +0100)
This reverts commit 90a9d5ff225267b3376f73c19f21174e3b6d7746 as it is
reported to cause boot regressions.

Link: https://lore.kernel.org/r/Y+rSXg14z1Myd8Px@dev-arch.thelio-3990X
Reported-by: Nathan Chancellor <nathan@kernel.org>
Cc: Longlong Xia <xialonglong1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/devtmpfs.c

index f273bcc..95ebc18 100644 (file)
@@ -389,18 +389,10 @@ static __initdata DECLARE_COMPLETION(setup_done);
 static int handle(const char *name, umode_t mode, kuid_t uid, kgid_t gid,
                  struct device *dev)
 {
-       int ret;
-
        if (mode)
-               ret = handle_create(name, mode, uid, gid, dev);
+               return handle_create(name, mode, uid, gid, dev);
        else
-               ret = handle_remove(name, dev);
-
-       if (ret)
-               dev_err(dev, "failed to %s %s, ret = %d\n",
-                       mode ? "create" : "remove", name, ret);
-
-       return ret;
+               return handle_remove(name, dev);
 }
 
 static void __noreturn devtmpfs_work_loop(void)