fix up cleanup handling in internal_vproblem

internal_vproblem can return, so this introduces proper cleanup
handling there.  Otherwise it may make a cleanup that is leaked.

	* utils.c (internal_vproblem): Call do_cleanups.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4f32385..4005a63 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2013-05-30  Tom Tromey  <tromey@redhat.com>
 
+       * utils.c (internal_vproblem): Call do_cleanups.
+
+2013-05-30  Tom Tromey  <tromey@redhat.com>
+
        * linespec.c (find_linespec_symbols): Don't reassign to 'cleanup'.
 
 2013-05-30  Tom Tromey  <tromey@redhat.com>

diff --git a/gdb/utils.c b/gdb/utils.c
index 218faed..c25dadf 100644 (file)
--- a/gdb/utils.c
+++ b/gdb/utils.c
@@ -713,6 +713,7 @@ internal_vproblem (struct internal_problem *problem,
   int quit_p;
   int dump_core_p;
   char *reason;
+  struct cleanup *cleanup = make_cleanup (null_cleanup, NULL);
 
   /* Don't allow infinite error/warning recursion.  */
   {
@@ -821,6 +822,7 @@ internal_vproblem (struct internal_problem *problem,
     }
 
   dejavu = 0;
+  do_cleanups (cleanup);
 }
 
 static struct internal_problem internal_error_problem = {